tools: add support for heuristic SCION traffic identification by wireshark #4582
Conversation
Made that default, since the dispacher removal makes port-based sorting flaky.
|
This change is |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jiceatscion)
tools/wireshark/scion.lua line 1175 at r2 (raw file):
-- Two options are available. Identify SCION traffic by port number, or heuristically, by -- looking for clues in the header. The heuristic is not extremely robust. It may mistake -- non-SCION packet for scion packets. If you know precisely which ports carry SCION
Suggestion:
SCION
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
tools/wireshark/scion.lua line 1175 at r2 (raw file):
-- Two options are available. Identify SCION traffic by port number, or heuristically, by -- looking for clues in the header. The heuristic is not extremely robust. It may mistake -- non-SCION packet for scion packets. If you know precisely which ports carry SCION
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jiceatscion)
a discussion (no related file):
additional fields that we could use:
- NextHdr
- DT/DL/ST/SL
But we can also leave it like this for now and refine later.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
a discussion (no related file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
additional fields that we could use:
- NextHdr
- DT/DL/ST/SL
But we can also leave it like this for now and refine later.
Good point, not many valid values for a SCION packet. Will do.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @lukedirtwalker)
a discussion (no related file):
Previously, jiceatscion wrote…
Good point, not many valid values for a SCION packet. Will do.
done
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)
Made that default, since the dispacher removal makes port-based sorting flaky.
Fixes #4545