build: drop @cgrindel_bazel_starlib//updatesrc

[oncilla]

Refactor the remaining targets that depended on @cgrindel_bazel_starlib//updatesrc. The repository has now been completely migrated to @aspect_bazel_lib//lib:write_source_files.

During the refactor, we dropped the functionality to write the source files in rules_openapi. Instead, the caller side can decide how to write the source files. This makes the rules more composable and easier to use. The functionality has been moved to a macro in private/mgmtapi/api.bzl, which is used inside of scionproto/scion.

---

This change is 

[matzf]

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

---

private/mgmtapi/api.bzl line 53 at r1 (raw file):

        name = name,
        srcs = out_files,
    )

Nit. This filegroup and the out_files seems redundant, it's identical to the files returned by _opeanpi_generate_go. I'd suggest to remove this for clarity and change the name of _openapi_generate_go to name.

---

rules_openapi/defs.bzl line 23 at r1 (raw file):

            '$(location " + name + "-no-header)' \
            '$(location " + name + ".bzl.gen.yml)' \
            '# GENERATED FILE DO NOT EDIT' \

Nit: can use $< and $@ shorthand for input and output files to make this shorter. Also, might not need the helper script, just

cmd = "(echo '# GENERATED FILE DO NOT EDIT'; cat $<) > $@",

[lukedirtwalker]

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @matzf)

---

private/mgmtapi/api.bzl line 53 at r1 (raw file):

Previously, matzf (Matthias Frei) wrote…

Nit. This filegroup and the out_files seems redundant, it's identical to the files returned by _opeanpi_generate_go. I'd suggest to remove this for clarity and change the name of _openapi_generate_go to name.

+1

---

rules_openapi/defs.bzl line 23 at r1 (raw file):

Previously, matzf (Matthias Frei) wrote…

Nit: can use $< and $@ shorthand for input and output files to make this shorter. Also, might not need the helper script, just

cmd = "(echo '# GENERATED FILE DO NOT EDIT'; cat $<) > $@",

+1

[oncilla]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

private/mgmtapi/api.bzl line 53 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

+1

Neat.

Done.

---

rules_openapi/defs.bzl line 23 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

+1

Done.

[lukedirtwalker]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @oncilla)

[oncilla]

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @oncilla)

[oncilla]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @oncilla)