FIX : unintended opening of urls #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @saadpasta on Vercel. @saadpasta first needs to authorize it. |
for more information, see https://pre-commit.ci
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saadpasta/developer-folio/FXbpscSyMitBWJtDsCXGu44eFXoL |
saadpasta
approved these changes
Sep 11, 2021
|
@allcontributors please add @JooHyukKim for code |
|
I've put up a pull request to add @JooHyukKim! 🎉 |
Mehranmzn
pushed a commit
to Mehranmzn/mehranmzn.github.io
that referenced
this pull request
Sep 13, 2024
* FIX : AchievementCard, url validation added to not open empty window * FIX : function openUrlInNewTab() not invoked properly * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was working on the achivementCard.js file to invalidate
window.openaction gets empty. Thought it will be okay to PR.There are couple of things to point out here.
#1
First what I found as trouble here was that not always you have url for a specific tag, or specific card.
Sometimes you just want to place keywords.
Not link to somewhere.
Even the master branch had some empty urls.
Made me realize it IS okay to not have urls sometimes.
Below are cases I tested and worked out alright.
#2
Second, some onClick callbacks did not even match the function names, So I fixed em up also.
#3
Lastly, I really appreciate your project.
Lemme know if anything,
cheers from Seoul, Korea