Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra landing space from header on smaller screens #382

Merged
merged 5 commits into from
Jun 24, 2021
Merged

Fix extra landing space from header on smaller screens #382

merged 5 commits into from
Jun 24, 2021

Conversation

gajanandh
Copy link
Contributor

@gajanandh gajanandh commented Jun 23, 2021 •
edited by kartikcho
Loading

Fixes #367

@vercel
Copy link

vercel bot commented Jun 23, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @saadpasta on Vercel.

@saadpasta first needs to authorize it.

@kartikcho
Copy link
Collaborator

Hey @gajanandh, thanks for the fix! I think this should fix it but let's check the preview deployment too. (@saadpasta authorize the preview)
Also, I see changes to the icons in the public folder and they shouldn't be related to the changes in this PR, do you know what's up with them and can you revert it for this PR?

@kartikcho kartikcho changed the title Pull request in resolution of issue #367 Fix extra landing space from header on smaller screens Jun 23, 2021
@kartikcho
Copy link
Collaborator

Also, updated the title and description to be more descriptive. (Using words like 'fixes' or 'addresses' will automatically close the associated issue too when this gets in)

You may add screenshots until the Preview deploy is up.

@gajanandh
Copy link
Contributor Author

Hello @kartikcho , I have not changed anything in public folder but somehow all the icons were staged for commit. Can you please tell me how to revert the changes

folio.mp4

@kartikcho
Copy link
Collaborator

kartikcho commented Jun 23, 2021 •
edited
Loading

One way to do it would be to revert the first commit and then only stage Header.scss with the relevant CSS changes. Don't use git add . and check if the only file you need to change for this PR is staged with git status

@vercel
Copy link

vercel bot commented Jun 24, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saadpasta/developer-folio/E7qzVMY2aUaCpjAKbVg959zeHaSA
✅ Preview: https://developer-folio-git-fork-gajanandh-master-saadpasta.vercel.app

@kartikcho
Copy link
Collaborator

@gajanandh the fix works, good job! Just revert the extra files committed in this PR and we should be good to go.

Also (unrelated to this PR), the header text doesn't use the old font anymore and I see the body font has been changed too, do you know about this change @naveen521kk @saadpasta?

@gajanandh
Copy link
Contributor Author

I tried to revert commit But I am not able to do it. It will helpful If you could elaborate how to do it

gajanand added 2 commits June 24, 2021 18:33
@gajanandh
Copy link
Contributor Author

I have reverted and commited only changes to Header.scss

kartikcho
kartikcho approved these changes Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@kartikcho kartikcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kartikcho kartikcho merged commit 865f6e5 into saadpasta:master Jun 24, 2021
@kartikcho
Copy link
Collaborator

@allcontributors please add @gajanandh for bug fixes.

@allcontributors allcontributors bot mentioned this pull request Jun 24, 2021
Merged
@allcontributors
Copy link
Contributor

@kartikcho

I've put up a pull request to add @gajanandh! 🎉

@naveen521kk
Copy link
Collaborator

Also (unrelated to this PR), the header text doesn't use the old font anymore and I see the body font has been changed too, do you know about this change @naveen521kk @saadpasta?

Can you create a new issue about this?

Mehranmzn pushed a commit to Mehranmzn/mehranmzn.github.io that referenced this pull request Sep 13, 2024
@gajanandh @pre-commit-ci @kartikcho
Fix extra landing space from header on smaller screens (saadpasta#382)
09bba8b 
* fixed extra space in header component

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert "fixed extra space in header component"

This reverts commit 00b97c6.

fixed extra space in header component

* fixed extra space in header component

* Fix whitespaces

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kartik Choudhary <kartikch918@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikcho kartikcho kartikcho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra landing space from header on smaller screens
3 participants
@gajanandh @kartikcho @naveen521kk