Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier version bump #379

Merged
merged 2 commits into from
Jun 20, 2021
Merged

Prettier version bump #379

merged 2 commits into from
Jun 20, 2021

Conversation

kartikcho
Copy link
Collaborator

Fixed a formatting error in master, this should also fix the failing check in other PRs like #365.

@vercel
Copy link

vercel bot commented Jun 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saadpasta/developer-folio/27zHr43uhm1PosSajH1dncFt3yVM
✅ Preview: https://developer-folio-git-format-fix-saadpasta.vercel.app

@naveen521kk
Copy link
Collaborator

Hmm, why does CI fail here?

@kartikcho
Copy link
Collaborator Author

Okay I think I figured out what's wrong with the prettier checks, it's only looking at master everytime as mentioned in the workflow config.

Running the same check locally gives me green, so this is definitely checking the current state of master everytime which is failing as of now.

image

@naveen521kk
Copy link
Collaborator

Okay I think I figured out what's wrong with the prettier checks, it's only looking at master everytime as mentioned in the workflow config.

Do you mean it checks out master each time it runs the checks (I mean the Github Action)?

@kartikcho
Copy link
Collaborator Author

Yes, master has formatting errors (which this PR addresses) and this is why formatting fails in every PR. And this action would also show green on PRs with formatting errors if the master is green.

@naveen521kk
Copy link
Collaborator

Yes, master has formatting errors (which this PR addresses) and this is why formatting fails in every PR. And this action would also show green on PRs with formatting errors if the master is green.

No, I don't think so. It checks out this branch (see the logs https://github.com/saadpasta/developerFolio/pull/379/checks?check_run_id=2868560528#step:2:40) correctly. Maybe it's about the prettier version, CI install's 2.3.1 and in package-lock.json it is 2.3.0 https://github.com/saadpasta/developerFolio/blob/master/package-lock.json#L10977. Can you try updating and locally and then run npm run format?

@kartikcho
Copy link
Collaborator Author

Good catch, you're right, it was a result of version mismatch

@kartikcho kartikcho changed the title Run prettier Prettier version bump Jun 20, 2021
@naveen521kk
Copy link
Collaborator

I think we should set up the depandabot to at least upgrade this.

Copy link
Collaborator

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naveen521kk naveen521kk merged commit 530f59f into master Jun 20, 2021
@naveen521kk naveen521kk deleted the format-fix branch June 20, 2021 11:08
Mehranmzn pushed a commit to Mehranmzn/mehranmzn.github.io that referenced this pull request Sep 13, 2024
* Run prettier

* prettier version bump, run format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants