-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier version bump #379
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saadpasta/developer-folio/27zHr43uhm1PosSajH1dncFt3yVM |
Hmm, why does CI fail here? |
Do you mean it checks out master each time it runs the checks (I mean the Github Action)? |
Yes, master has formatting errors (which this PR addresses) and this is why formatting fails in every PR. And this action would also show green on PRs with formatting errors if the master is green. |
No, I don't think so. It checks out this branch (see the logs https://github.com/saadpasta/developerFolio/pull/379/checks?check_run_id=2868560528#step:2:40) correctly. Maybe it's about the prettier version, CI install's |
Good catch, you're right, it was a result of version mismatch |
I think we should set up the depandabot to at least upgrade this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Run prettier * prettier version bump, run format
Fixed a formatting error in master, this should also fix the failing check in other PRs like #365.