Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop-rspec
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.0
Choose a base ref
...
head repository: rubocop/rubocop-rspec
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.4.0
Choose a head ref
  • 18 commits
  • 27 files changed
  • 8 contributors

Commits on Apr 28, 2021

  1. Switch docs version back to master

    @bquorning
    bquorning committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    721fd6c View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Fix InternalAffairs/ExampleDescription offenses on master

    @tejasbubane
    tejasbubane committed May 21, 2021
    Configuration menu
    Copy the full SHA
    dd40ff8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1154 from tejasbubane/fix-failing-rubocop 

    Fix `InternalAffairs/ExampleDescription` offenses on master
    @pirj
    pirj committed May 21, 2021
    Configuration menu
    Copy the full SHA
    78d1ae4 View commit details
    Browse the repository at this point in the history

  3. Add missing documentation for single_statement_only style of `RSpec… 

    …/ImplicitSubject` cop
    @tejasbubane
    tejasbubane committed May 21, 2021
    Configuration menu
    Copy the full SHA
    35fe00b View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1155 from tejasbubane/implicit-subject-missing-doc 

    Add missing documentation for `single_statement_only` style of `RSpec/ImplicitSubject` cop
    @pirj
    pirj committed May 21, 2021
    Configuration menu
    Copy the full SHA
    a01cc07 View commit details
    Browse the repository at this point in the history

  5. Fix an exception in DescribedClass when accessing a constant on a var… 

    …iable in a namespaced spec
    @rrosenblum
    rrosenblum committed May 21, 2021
    Configuration menu
    Copy the full SHA
    88a8f54 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Merge pull request #1156 from rrosenblum/described_class 

    Fix an exception in DescribedClass when accessing a constant on a variable in a namespaced spec
    @pirj
    pirj committed May 24, 2021
    Configuration menu
    Copy the full SHA
    cb5c0dc View commit details
    Browse the repository at this point in the history

  2. Add new RSpec/IdenticalEqualityAssertion cop 

    Closes #1130
    @tejasbubane
    tejasbubane committed May 24, 2021
    Configuration menu
    Copy the full SHA
    cada3e0 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Merge pull request #1132 from tejasbubane/fix-1130 

    Add new `RSpec/IdenticalEqualityAssertion` cop
    @pirj
    pirj committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e0e109c View commit details
    Browse the repository at this point in the history

  2. Add RSpec/Rails/AvoidSetupHook cop

    @paydaylight @pirj
    paydaylight authored and pirj committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e94b463 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1133 from paydaylight/add-prefer-before-over-setu… 

    …p-cop

Add new RSpec/AvoidSetupHook cop
    @pirj
    pirj committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9e55194 View commit details
    Browse the repository at this point in the history

  4. Fix false negative in RSpec/ExpectChange cop with block style and c… 

    …hained method call

Closes #1143
    @tejasbubane @pirj
    tejasbubane authored and pirj committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c3dd64a View commit details
    Browse the repository at this point in the history

  5. Add more specs for RSpec/ExpectChange

    @pirj
    pirj committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0cbc140 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1152 from tejasbubane/fix-1143 

    Fix false negative in `RSpec/ExpectChange` cop with block style and chained method call
    @pirj
    pirj committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0be6148 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Make FilePath check suffix when given a non-const top-level node 

    This helps with the standard feature format:

RSpec.feature "Some feature" do; end
    @topalovic
    topalovic committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    c4646ff View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1158 from topalovic/file-path-check-suffix-for-no… 

    …n-const

Make FilePath check suffix when given a non-constant top-level node
    @bquorning
    bquorning committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    2d00dbb View commit details
    Browse the repository at this point in the history

  3. Bump version to 2.4.0

    @bquorning
    bquorning committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    b82febd View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1159 from rubocop/release 

    Bump version to 2.4.0
    @bquorning
    bquorning committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    1b360e5 View commit details
    Browse the repository at this point in the history
Loading