This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 278
feat: make tileboard installable as web apk #822
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI: I've acknowledged this PR but didn't have time to look into it yet. |
Thanks for the feedback! We're in no hurry, things are working swiftly already: I have just kept my once installed app from my test branch. ;-) |
Made minor changes:
|
The manifest changes haven't made it to the PR yet. |
rchl
approved these changes
Jun 19, 2022
Yeay! Thanks. I believe |
I've misinterpreted my local changes after all this time and thought that this was something that I've added when experimenting... |
akloeckner
added a commit
to akloeckner/TileBoard
that referenced
this pull request
Jun 20, 2022
This is a requirement for installable web APKs. See resoai#822 and criteria in resoai#819 (comment) .
I verified that start_url is needed to show the install button on my Windows Chrome. I opened #838 to fix this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #819
This
The service worker's scope is automatically just the path to its js file. (See Google's primer on it.)
The ingress mode of the addon can disable the service worker via
window.IN_INGRESS = true
. See PR there: resoai/TileBoard-addon#32.