Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

feat: make tileboard installable as web apk #822

Merged
merged 10 commits into from
Jun 19, 2022
Merged

Conversation

akloeckner
Copy link
Contributor

@akloeckner akloeckner commented Mar 10, 2022

fixes #819

This

  • adds a dummy service worker with a fetch handler
  • increases the favicon size to 512px and adds a vector source graphic
  • adds a start_url to the webmanifest

The service worker's scope is automatically just the path to its js file. (See Google's primer on it.)

The ingress mode of the addon can disable the service worker via window.IN_INGRESS = true. See PR there: resoai/TileBoard-addon#32.

@rchl
Copy link
Collaborator

rchl commented Mar 29, 2022

FYI: I've acknowledged this PR but didn't have time to look into it yet.

@akloeckner
Copy link
Contributor Author

Thanks for the feedback! We're in no hurry, things are working swiftly already: I have just kept my once installed app from my test branch. ;-)

@rchl
Copy link
Collaborator

rchl commented Apr 6, 2022

Made minor changes:

  • optimized SVG
  • declared SVG favicon in the manifest and added 256x256 size also
  • small style changes

@akloeckner
Copy link
Contributor Author

The manifest changes haven't made it to the PR yet.

@rchl rchl merged commit a1dd248 into resoai:master Jun 19, 2022
@akloeckner
Copy link
Contributor Author

Yeay! Thanks.

I believe start_url is a requirement, though. I just did a quick test on my mobile and didn't get the "install" option. I'll check again on a laptop as soon as I find time.

@rchl
Copy link
Collaborator

rchl commented Jun 20, 2022

I've misinterpreted my local changes after all this time and thought that this was something that I've added when experimenting...
Should definitively restore it then.

akloeckner added a commit to akloeckner/TileBoard that referenced this pull request Jun 20, 2022
This is a requirement for installable web APKs. See resoai#822 and criteria in resoai#819 (comment) .
@akloeckner
Copy link
Contributor Author

I verified that start_url is needed to show the install button on my Windows Chrome. I opened #838 to fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samsung phones: Progressive Web App lacks service worker
2 participants