-
Notifications
You must be signed in to change notification settings - Fork 278
Conversation
also export the moment class to user space this will enable the user to do ``` moment.locale('de'); ``` in their `config.js`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds quite a chunk of data to the bundle (maybe 500kb or so) but I guess it's probably fine.
I tried to find a way to avoid bundling all the locales. We could only bundle "popular" locales like ru, de, en, pl. Or provide info on how the user can load locales. Both don't seem very appealing to me... |
Actually, |
da64927
to
c861478
Compare
So, this is a simple one now... I'll PR i18n separately... |
I've briefly looked at using I'll wait to hear what you have to say about that before merging this one. (We would still have to include moment.js for the |
I think, it's good to stick with moment.js until we sort this out once and for all. Since chart.js uses moments we might even end up deciding to stick with it despite its deprecation. Wrapping in a function wouldn't really stop me from using it, though. Currently |
BTW. If we advertise the use of something like |
also export the moment class to user space
this will enable the user to do
in their
config.js
.