fix(LIGHT): show color picker based on feature check

[rchl]

This is a behavior change since now even if the user doesn't define
sliders and the light supports color change, then picker will still show up
on long press.

We maybe should leave support for "item.colorpicker" to be able to
override it to "false" but not sure if it's worth it.

@akloeckner

[akloeckner]

I believe, we discussed in #313 that we wanted to make an automatic history/brightness/temperature/color popup for this.

However, I actually like the slim looks of the light sliders on the tile. It's just not usable for me, since it turns on the light on full brightness before I even get a chance to adjust the brightness (see #312).

So, in general, I believe we should revisit the whole light slider thing. Either by a popup. Or by changed long-press behavior plus automatic slider configuration. I just wonder where we'd put a history graph then, if we want it to be available for lights.

That being said, more automatic configurations are a good thing. Still, the major point TileBoard makes is its being customizable. So, I'd prefer to allow overriding automatic choices, here with colorpicker: false. Plus, if we automate the colorpicker, we should certainly also automate brightness. And possibly color temperature, too.

Do you maybe see a way to have overrideable default choices? E.g., don't check item.colorpicker, but check itemField('colorpicker', item, entity). Then, merge in a DEFAULT_SETTINGS.LIGHT here (or any other place you see more fit):

TileBoard/scripts/controllers/main.js

Line 2152 in e796af5

let value = item;

with

DEFAULT.LIGHT = { 
   ...
   colorpicker = (item, entity) => supportsFeature(FEATURES.LIGHT.COLOR, entity)
   ...};

Would that make sense? We could then easily add lots of default options. And make all of them overrideable...

[rchl]

I've done as you've suggested with the exception that I'm not merging defaults dynamically from getItemFieldValue but initially on loading the app. That won't introduce any runtime overhead.

[akloeckner]

Very nice new capacity! I'll need some time to check it out. But I'm excited!

[akloeckner]

Looks great, just a few comments that might help improve even more.

[akloeckner]

Should we explain somewhere in the docs that the following will now be possible in config.js?

TILE_DEFAULTS[TYPES.LIGHT].colorpicker = false;

Maybe be even add a line to the example:

TILE_DEFAULTS = angular.merge(TILE_DEFAULTS, {
   // override defaults here, e.g.:
   [TYPES.LIGHT]: {
      colorpicker: false
   }
});

[rchl]

We should but I haven't figured out a way to state that in a generic way. Maybe we should wait until we have all tiles covered that way because now the instructions would have to be rather specific.

[akloeckner]

Also fine with me, that would give us time to sort out last issues with this new scheme before people start to use it. I'll certainly help find those issues, because I'll switch my whole setup to use the defaults.

We just shouldn't forget...

[akloeckner]

Also fine with me, that would give us time to sort out last issues with this new scheme before people start to use it. I'll certainly help find those issues, because I'll switch my whole setup to use the defaults.

We just shouldn't forget...

[akloeckner]

No further comments. This is a great improvement!