Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsc] Generated .rei files changed function name #3094

Closed
wyze opened this issue Oct 12, 2018 · 2 comments
Closed

[bsc] Generated .rei files changed function name #3094

wyze opened this issue Oct 12, 2018 · 2 comments

Comments

@wyze
Copy link
Contributor

wyze commented Oct 12, 2018

This was working correctly in bs-platform 4.0.5, but started running into this when I upgraded to 4.0.6.

Source

type ex;
[@bs.val] external expect: Dom.element => ex = "";
[@bs.get] external not_: ex => ex = "not";

Command

$ bsc -bs-re-out lib/bs/src/File.cmi > src/File.rei

Output

type ex;
[@bs.val] external expect: Dom.element => ex = "";
[@bs.get] external not__: ex => ex = "not";

Error

[2/3] Building src/JestDom.cmj

  We've found a bug for you!
  /Users/neil/Projects/personal/bs-jest-dom/src/JestDom.re

  The implementation src/JestDom.mlast
       does not match the interface src/jestDom.cmi:
       The value `not__' is required but not provided

error Command failed with exit code 2.

Expected

type ex;
[@bs.val] external expect: Dom.element => ex = "";
[@bs.get] external not_: ex => ex = "not";
@bobzhang
Copy link
Member

@chenglou this seems to be a regression in reason oprinter?

caulagi added a commit to ishakuni/frontend that referenced this issue Oct 26, 2018
caulagi added a commit to ishakuni/frontend that referenced this issue Oct 26, 2018
* Test real component being rendered on page

* Fix tests

* Remove eslintConfig from package.json - see facebook/create-react-app#649
* Use latest version of yarn
* Tidy packages - reason-react is a dependency, not dev-dependency
* Need to run bsb -make-world before running tests
* No need to run build before test

* Run clean before test

* reason-scripts is dev dependency
* Test if this caches ocaml building each time

* Fix tests - rescript-lang/rescript-compiler#3094

* Pin version correctly and remove linking bs-platform
@bobzhang
Copy link
Member

moved to reason repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants