-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modify): BREAKING CHANGE - Change the return result to include warnings #83
Merged
sandrina-p
merged 7 commits into
main
from
pbyr-1417-jsf-modify-module-explicit-warnings
Jul 24, 2024
Merged
feat(modify): BREAKING CHANGE - Change the return result to include warnings #83
sandrina-p
merged 7 commits into
main
from
pbyr-1417-jsf-modify-module-explicit-warnings
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrina-p
requested review from
danielcardoso5 and
eng-almeida
and removed request for
danielcardoso5
July 24, 2024 08:59
sandrina-p
commented
Jul 24, 2024
eng-almeida
reviewed
Jul 24, 2024
sandrina-p
force-pushed
the
pbyr-1417-jsf-modify-module-explicit-warnings
branch
from
July 24, 2024 11:48
42b31ca
to
0229b4b
Compare
sandrina-p
commented
Jul 24, 2024
danielcardoso5
approved these changes
Jul 24, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #71.
Linear issue (internal)
Now the result is an object with both
schema
andwarn
. Thewarn
will be an array of all warnings highlighting unexpected changes. This can help you spot and avoid possible bugs with your modifications.Before
Now
The
warnings
is an array of objects (list of warnings), each one with atype
andmessage
. Eg:Remembering the warnings
When using
modify()
, it will also log aconsole.warn
by default calling you out to handle thewarnings
on your behalf. For example, report it to your error tracking systems.You can disable the log by passing
muteWarningTip
References: