make omar happy #1108
Merged
make omar happy #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2016 14:45
This reverts commit 4c32c52.
add definition of 'COMMON_TEST' macro to eunit provider
|
also this makes @omarkj |
|
I'm ok with this change but not positive it is what everyone wants? @ferd |
|
Well it sure worked before then. PErsonally the macro definition changes nothing since including eunit.hrl defines both anyway and I always include eunit's assertions. I'm okay with it, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this change 'EUNIT' will only be set when running the eunit provider and 'COMMON_TEST' will be set by the ct provider. this does mean users that run both eunit and ct tests will see a recompile when alternating between the two test runners