only apply default and prod profile to dependencies #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. Remind me to write a test checking that other profiles aren't accidentally run. |
ferd
added a commit
that referenced
this pull request
Jan 9, 2016
only apply default and prod profile to dependencies
|
Ah forgot to ask -- does this display warnings on deps without prod profiles? |
|
Isn't that warning only if you use |
|
That's possible, I forgot where we put that. That would make sense though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #998
When implementing this I discovered we actually were applying profiles to dependencies! This removes that mistake and only applies the
prodprofile to dependencies.The reason we didn't notice is this only happened in
handle_depwhich would not be called for a dep when sayrebar3 eunitis run because the dep was already fetched todefault, so thetestprofile wouldn't be wrongly applied to it, it would only happen for test deps, which is still wrong and now won't happen.