Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android to Material Design 3 #790

Open
Harry-Dang opened this issue Jul 16, 2023 · 3 comments
Open

Update Android to Material Design 3 #790

Harry-Dang opened this issue Jul 16, 2023 · 3 comments

Comments

@Harry-Dang
Copy link

Feature request

Update the date time picker from Material Design 2 to Material Design 3

With the release of Android 12 in 2021, Android's native design language has updated from Material Design 2 to Material Design 3. This change brought a complete redesign to Android including the native date picker. By updating to MD3, the date picker would be aligned with other modern native Android components

As an aside, it would be nice to include support for Material You which would add style support as requested in #572

Why it is needed

Modern Android follows Google's new Material Design 3 design language. To keep this library in line with modern Android, the date picker needs to be updated

Possible implementation

I'm not too familiar with Android development anymore, but I believe you would need to replace the current use of android.widget.DatePicker with com.google.android.material.datepicker (similar for the TimePicker)

@vonovak
Copy link
Member

vonovak commented Jul 19, 2023

Hello and thanks for asking,
yes, it indeed would be nice to have those, as I mentioned in #313 (comment). It'd also allow to bring many new features such as disabling dates (#815).

However "you would need to replace the current use of android.widget.DatePicker with com.google.android.material.datepicker (similar for the TimePicker)" is a pretty big chunk of work.

PRs that would do this work are welcome. I maintain this library from open collective sponsorships, but there are not enough of them for me to work on major updates like this one. It's as simple as that 🤷

Thank you 🙂

@camilossantos2809
Copy link

This feature would be very interesting, is there any work being done on this already? Which files would need to be migrated, just the RNDatePickerDialogFragment? Would the idea be to replace it or create another component?

@psycho-baller
Copy link

Found this repo while looking for RN datetime pickers that use Material Design 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants