Check inputs before caching

R/resp-body.R

@@ -78,13 +78,14 @@ resp_body_string <- function(resp, encoding = NULL) {
 #' @rdname resp_body_raw
 #' @export
 resp_body_json <- function(resp, check_type = TRUE, simplifyVector = FALSE, ...) {
+  check_response(resp)
+  check_installed("jsonlite")
+
   key <- body_cache_key("json", simplifyVector = simplifyVector, ...)
   if (env_has(resp$cache, key)) {
     return(resp$cache[[key]])
   }
 
-  check_response(resp)
-  check_installed("jsonlite")
   resp_check_content_type(
     resp,
     valid_types = "application/json",
@@ -114,14 +115,14 @@ resp_body_html <- function(resp, check_type = TRUE, ...) {
 #' @rdname resp_body_raw
 #' @export
 resp_body_xml <- function(resp, check_type = TRUE, ...) {
+  check_response(resp)
+  check_installed("xml2")
+
   key <- body_cache_key("xml", ...)
   if (env_has(resp$cache, key)) {
     return(resp$cache[[key]])
   }
 
-
-  check_response(resp)
-  check_installed("xml2")
   resp_check_content_type(
     resp,
     valid_types = c("application/xml", "text/xml"),

tests/testthat/_snaps/resp-body.md

@@ -14,6 +14,19 @@
       Error in `resp_body_raw()`:
       ! Can't retrieve empty body.
 
+# check argument types before caching
+
+    Code
+      resp_body_json(1)
+    Condition
+      Error in `resp_body_json()`:
+      ! `resp` must be an HTTP response object, not the number 1.
+    Code
+      resp_body_xml(1)
+    Condition
+      Error in `resp_body_xml()`:
+      ! `resp` must be an HTTP response object, not the number 1.
+
 # content types are checked
 
     Code

tests/testthat/test-resp-body.R

@@ -57,6 +57,13 @@ test_that("resp_body_xml stores parsed result", {
   expect_true(is_reference(xml2, xml1))
 })
 
+test_that("check argument types before caching", {
+  expect_snapshot(error = TRUE, {
+    resp_body_json(1)
+    resp_body_xml(1)
+  })
+})
+
 test_that("content types are checked", {
   expect_snapshot(error = TRUE, {
     request_test("/xml") %>% req_perform() %>% resp_body_json()