GetStyle does not return DecimalPlaces

[mlorenz-tug]

Description

Currently getting a style using GetStyle does not return the previously set DecimalPlaces property. If this setting is retained in the Excel file this should also be read in the GetStyle method.

Steps to reproduce the issue:
1.

style1 := &excelize.Style{
  Font: &excelize.Font{
    Bold: true,
  },
}
x := 2
style2 := &excelize.Style{
  DecimalPlaces: &x,
  NumFmt:        2,
}

f := excelize.NewFile()

s1, _ := f.NewStyle(style1)
s2, _ := f.NewStyle(style2)

ss1, _ := f.GetStyle(s1)
ss2, _ := f.GetStyle(s2)

fmt.Printf("%+v\n", ss1)
fmt.Printf("%+v\n", ss2)

Describe the results you received:

&{Border:[] Fill:{Type: Pattern:0 Color:[] Shading:0} Font:0xc00027eb60 Alignment:<nil> Protection:<nil> NumFmt:0 DecimalPlaces:<nil> CustomNumFmt:<nil> NegRed:false}
&{Border:[] Fill:{Type: Pattern:0 Color:[] Shading:0} Font:<nil> Alignment:<nil> Protection:<nil> NumFmt:2 DecimalPlaces:<nil> CustomNumFmt:<nil> NegRed:false}

DecimalPlaces is nil in both outputs. It makes sense in the first style, since no decimal places were set there.

Describe the results you expected:

In the second output one would expect DecimalPlaces to be set to 2 (pointer to variable set to 2 to be specific).

Output of go version:

go version go1.21.5 linux/amd64

Excelize version or commit ID:

github.com/xuri/excelize/v2 v2.8.0

Environment details (OS, Microsoft Excel™ version, physical, etc.):

[xuri]

Thanks for your issue. I have fixed it. Please upgrade to the master branch code. This patch will be released in the next version. In addition, there are some special cases for using the NewStyle and GetStyle functions:

package main

import (
    "fmt"

    "github.com/xuri/excelize/v2"
)

func main() {
    f := excelize.NewFile()
    defer func() {
        if err := f.Close(); err != nil {
            fmt.Println(err)
        }
    }()

    // Example 1: DecimalPlaces doesn't work if we have specified NumFmt with
    // built-in all languages formats or built-in language
    decimalPlaces := 4
    styleID, err := f.NewStyle(&excelize.Style{
        NumFmt:        2, // 0.00
        DecimalPlaces: &decimalPlaces,
    })
    if err != nil {
        fmt.Println(err)
        return
    }
    style, err := f.GetStyle(styleID)
    if err != nil {
        fmt.Println(err)
        return
    }
    fmt.Printf("DecimalPlaces: %d\r\n", *style.DecimalPlaces)
    // DecimalPlaces: 2

    // Example 2: DecimalPlaces doesn't work if we have specified CustomNumFmt
    customNumFmt := "0.0"
    styleID, err = f.NewStyle(&excelize.Style{
        CustomNumFmt:  &customNumFmt,
        DecimalPlaces: &decimalPlaces,
    })
    if err != nil {
        fmt.Println(err)
        return
    }
    style, err = f.GetStyle(styleID)
    if err != nil {
        fmt.Println(err)
        return
    }
    fmt.Printf("DecimalPlaces: %d\r\n", *style.DecimalPlaces)
    // DecimalPlaces: 1

    // Example 3: get style definition by the GetStyle or GetConditionalStyle
    // function, the DecimalPlaces is nil if a number format code has the
    // different decimal places in the positive part and negative part
    customNumFmt = "0.0;0.00"
    styleID, err = f.NewStyle(&excelize.Style{
        CustomNumFmt: &customNumFmt,
    })
    if err != nil {
        fmt.Println(err)
        return
    }
    style, err = f.GetStyle(styleID)
    if err != nil {
        fmt.Println(err)
        return
    }
    fmt.Printf("DecimalPlaces: %v\r\n", style.DecimalPlaces)
    // DecimalPlaces: <nil>

    // Example 4: get style definition by the GetStyle or GetConditionalStyle
    // function, the DecimalPlaces is nil if a number format code only have the
    // negative part
    customNumFmt = ";0.00"
    styleID, err = f.NewStyle(&excelize.Style{
        CustomNumFmt: &customNumFmt,
    })
    if err != nil {
        fmt.Println(err)
        return
    }
    style, err = f.GetStyle(styleID)
    if err != nil {
        fmt.Println(err)
        return
    }
    fmt.Printf("DecimalPlaces: %v\r\n", style.DecimalPlaces)
    // DecimalPlaces: <nil>

    // Example 5: get style definition by the GetStyle or GetConditionalStyle
    // function, the NumFmt is not equal with the value when create the style
    decimalPlaces = 4
    styleID, err = f.NewStyle(&excelize.Style{
        NumFmt:        165,            // [$$-409]#,##0.00
        DecimalPlaces: &decimalPlaces, // change [$$-409]#,##0.00 to [$$-409]#,##0.0000
    })
    if err != nil {
        fmt.Println(err)
        return
    }
    style, err = f.GetStyle(styleID)
    if err != nil {
        fmt.Println(err)
        return
    }
    fmt.Printf("NumFmt: %d\r\n", style.NumFmt)
    // NumFmt: 0
}