Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPy: improve ignite.base module #1342

Closed
vfdev-5 opened this issue Oct 3, 2020 · 5 comments · Fixed by #1365
Closed

MyPy: improve ignite.base module #1342

vfdev-5 opened this issue Oct 3, 2020 · 5 comments · Fixed by #1365

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 3, 2020

🚀 Feature

Currently, mypy ignores all errors for all modules. We have to rework our typing such that mypy checks the code.
In this issue, let's improve https://github.com/pytorch/ignite/tree/master/ignite/base module such that mypy passes on it.

For Hacktoberfest contributors, feel free to ask questions for details if any and say that you would like to tackle the issue.
Please, take a look at CONTRIBUTING guide.

@thescripted
Copy link
Contributor

Hey, would love to contribute! I've read through the contributing guide & should be able to complete this over the weekend.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 3, 2020

Thanks @thescripted ! Let me assign it to you.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 5, 2020

@thescripted will you work on this issue today or tomorrow ? As we have another PR dependent on this issue, it would be nice to have this one resolved quickly.

@thescripted
Copy link
Contributor

Writing up a PR as we speak (:

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 5, 2020

@thescripted thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants