Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 738: Android support, draft 2 #3651

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Feb 8, 2024

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

Updates following discussion on Discourse:

  • Reduce minimum Android API level from 23 to 21.
  • Add more device information fields to platform.android_ver.

Other changes:

  • State that a python3.x executable will not be officially supported on this platform. For the reasons explained in "App lifecycle", this would be of very little use.
  • Add another reason why libpython must be dynamically linked.
  • Add details of stdin, stdout, and stderr.
  • Remove spwd from unsupported modules list, since it's already been removed from Python 3.13.

@freakboy3742: FYI


📚 Documentation preview 📚: https://pep-previews--3651.org.readthedocs.build/

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of comments about accessibility.

peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good set of improvements and clarifications; a couple of minor nits/questions inline.

peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
@encukou encukou dismissed freakboy3742’s stale review February 13, 2024 15:16

The comments were resolved.

@encukou encukou merged commit fda02b5 into python:main Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants