PEP 594: add myself as co-author and target for Python 3.11

[brettcannon]

No description provided.

[JelleZijlstra]

Thanks, a couple of pieces of feedback

[JelleZijlstra]

Thanks for helping to push this forward!

[gvanrossum]

Does it sound like the SC would accept this? That would be great!

[CAM-Gerlach]

Excited to see this finally moving forward again! Happy to assist in seeing this through; if I can help with PEP updates/editing or the more mechanical tasks in the CPython repo, feel free to ping me here or on the Discourse thread.

Review in progress...

[CAM-Gerlach]

Thanks again, @brettcannon ! I've got a mix of small textual suggestions and substantive content questions/comments. The one thing I didn't check was maintainer/expert status of the modules, as that would be rather time-intensive, but I can if that would be helpful. Thanks!

[CAM-Gerlach]

Also, @brettcannon , don't forget to add yourself to CODEOWNERS :)

[brettcannon]

@JelleZijlstra I unfortunately wasn't done with this PR (I'm actually actively editing it right now and pushing my branch as I go), hence the unresolved conversations.

I'll create a separate PR for the changes I'm currently making.

[JelleZijlstra]

Sorry for that! I interpreted the review request as an indication that you were ready.

[brettcannon]

I actually didn't make the review request; GitHub did automatically when I edited CODEOWNERS.

[CAM-Gerlach]

Just FYI @brettcannon @JelleZijlstra using Github's "Draft" option for creating the PR (or "convert to draft" under the reviewers list afterwards) is very useful for situations like these, to prevent others merging it while you're working on it and send a clear signal that it is a work in progress.

[brettcannon]

@CAM-Gerlach correct, but the PR was submitted in a form I was ready to merge. You just happened to disagree. 😉 So this wasn't an issue about me putting up a PR I wasn't to have merged from the start, but Jelle seeing a buggy signal from GitHub that somehow I was ready for another round of reviews and thus was done. I don't think constantly flipping a PR from draft to ready while addressing reviews is a common practice.

[CAM-Gerlach]

Oh sorry, I wasn't referring to my review comments at all—what I meant was what what I presumed were other additional changes you were continuing to iterate on yourself (the cgi stuff?) that I thought you were referring to in your reply to Jelle mentioning that the merge was premature—

@JelleZijlstra I unfortunately wasn't done with this PR (I'm actually actively editing it right now and pushing my branch as I go)

But maybe I misunderstood what you were saying there? I certainly wasn't suggesting flipping draft mode back and forth when responding to discussions, just while you still had changes you wanted to make on the PR (or there was some other important reason why it shouldn't be merged once approved).

For avoiding merges when there are unresolved discussions, we could consider enabled the corresponding feature of GitHub branch protection which puts an alert and a count if there are unresolved review comments in the merge box, and ensures discussions are resolved (or the check is explicitly overriden) before merging. It really has come in handy on our various repos, since it can get hard to keep track (even by those involved) if there are a lot of discussions or a lag between them.

[brettcannon]

what I meant was what what I presumed were other additional changes you were continuing to iterate on yourself (the cgi stuff?) that I thought you were referring to in your reply to Jelle mentioning that the merge was premature

I was referring to Jelle merging the PR while I was in the middle of addressing your review comments. Other stuff I am doing for the PEP are going to be done in separate PRs.

[CAM-Gerlach]

Oh okay, gotcha. Sorry I misunderstood and thanks for clarifying!