Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91058: Add what's new entry for the improvement in commit 7cfbb49fcd4c85f9bab3797302eadf93df490344 #99198

Merged
merged 3 commits into from
Nov 7, 2022
Merged

gh-91058: Add what's new entry for the improvement in commit 7cfbb49fcd4c85f9bab3797302eadf93df490344 #99198

merged 3 commits into from
Nov 7, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 7, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Nov 7, 2022
Closed
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Nov 7, 2022
AlexWaygood
AlexWaygood reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
pablogsal and others added 2 commits November 7, 2022 12:37
@pablogsal @AlexWaygood
Update Doc/whatsnew/3.12.rst
3c847fc 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@pablogsal @AlexWaygood
Update Doc/whatsnew/3.12.rst
42aca98 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@pablogsal
Copy link
Member Author

thanks @AlexWaygood ❤️

AlexWaygood
AlexWaygood approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (And thank you for the awesome feature, it's going to save so much pain ❤️)

@pablogsal pablogsal merged commit be31ecf into python:main Nov 7, 2022
@pablogsal pablogsal deleted the whatsnew2 branch November 7, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
awaiting merge docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @AlexWaygood @bedevere-bot