gh-98989: configure: add 3.11 to list of Pythons #98988
Conversation
JelleZijlstra
commented
Nov 2, 2022
•
JelleZijlstra
commented
- Issue: configure on main branch does not look for python3.11 #98989
|
I'll add an issue and NEWS since the bug went out in 3.12a1 and could affect some users. |
There was a problem hiding this comment.
Don't take my word for it, this is probably up to @tiran or @brettcannon to review.
JelleZijlstra
changed the title
| @@ -203,7 +203,7 @@ AC_SUBST([FREEZE_MODULE_DEPS]) | |||
| AC_SUBST([PYTHON_FOR_BUILD_DEPS]) | |||
|
|
|||
| AC_CHECK_PROGS([PYTHON_FOR_REGEN], | |||
| [python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python], | |||
| [python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python], | |||
There was a problem hiding this comment.
Worth queuing up a couple versions?
|
Something to add to PEP 101 (Doing Python Releases)? |
| @@ -203,7 +203,7 @@ AC_SUBST([FREEZE_MODULE_DEPS]) | |||
| AC_SUBST([PYTHON_FOR_BUILD_DEPS]) | |||
|
|
|||
| AC_CHECK_PROGS([PYTHON_FOR_REGEN], | |||
| [python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python], | |||
| [python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python], | |||
There was a problem hiding this comment.
Why are we allowing python3.8 and lower in the first place if we know that 3.9+ is required?
There was a problem hiding this comment.
If 3.9 or higher is required, we should remove the earlier and incompatible versions.
There was a problem hiding this comment.
Guido said he wanted to remove the 3.9+ dependency that crept into one of the scripts. Increasing the minimum required version might need more discussion as it could make bootstrapping harder for some.
There was a problem hiding this comment.
Ok sure let's get this in first as this is failing randomly on PRs.
There was a problem hiding this comment.
@erlend-aasland any objections to landing this?
There was a problem hiding this comment.
Nah, good to good for my part :)
Misc/NEWS.d/next/Build/2022-11-01-21-45-58.gh-issue-98989.tMxbdB.rst
Outdated
Show resolved
Hide resolved
…dB.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
