Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96478: Fix new test when run in refleak mode #96615

Merged
merged 1 commit into from
Sep 6, 2022
Merged

gh-96478: Fix new test when run in refleak mode #96615

merged 1 commit into from
Sep 6, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Sep 6, 2022 •
edited by bedevere-bot
Loading

./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.

@JelleZijlstra
pythongh-96478: Fix new test when run in refleak mode
b80acd1 
./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 6, 2022
@JelleZijlstra
Copy link
Member Author

cc @sobolevn

sobolevn
sobolevn reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see! Thanks!

The difference is that other test calls clear_overloads() in the end.

@JelleZijlstra JelleZijlstra merged commit f0d9136 into python:main Sep 6, 2022
@JelleZijlstra JelleZijlstra deleted the fixoverl branch September 6, 2022 16:33
@sobolevn sobolevn mentioned this pull request Sep 6, 2022
Merged
@vstinner vstinner added the needs backport to 3.11 only security fixes label Sep 27, 2022
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 27, 2022
@bedevere-bot
Copy link

GH-97601 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2022
@JelleZijlstra @miss-islington
pythongh-96478: Fix new test when run in refleak mode (pythonGH-96615)
77acaf2 
./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
(cherry picked from commit f0d9136)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington added a commit that referenced this pull request Sep 27, 2022
@miss-islington @JelleZijlstra
gh-96478: Fix new test when run in refleak mode (GH-96615)
f391b3c 
./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
(cherry picked from commit f0d9136)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@zware zware zware approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JelleZijlstra @miss-islington @bedevere-bot @sobolevn @zware @vstinner @AlexWaygood