-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96497: Mangle name before symtable lookup in 'symtable_extend_namedexpr_scope' #96561
Conversation
EDIT: Seems rerunning the checks fixed it. Thanks. |
Hi, would anyone be able to give this PR a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @wookie184 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…d_namedexpr_scope' (pythonGH-96561) (cherry picked from commit 664965a) Co-authored-by: wookie184 <wookie1840@gmail.com>
GH-115603 is a backport of this pull request to the 3.12 branch. |
Sorry, @wookie184 and @serhiy-storchaka, I could not cleanly backport this to
|
…e_extend_namedexpr_scope' (pythonGH-96561) (cherry picked from commit 664965a) Co-authored-by: wookie184 <wookie1840@gmail.com>
GH-115604 is a backport of this pull request to the 3.11 branch. |
…d_namedexpr_scope' (pythonGH-96561)
…d_namedexpr_scope' (pythonGH-96561)
Closes #96497
Previously, the non-mangled name was being looked up for assignment expressions in comprehensions, which caused some bugs. See issue for more information.