Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-80480: Emit DeprecationWarning for array's 'u' type code #95760

Merged
merged 14 commits into from
Jun 11, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 7, 2022

The "u" type code for array was deprecated in Python 3.3 but only via documentation: https://docs.python.org/3.10/library/array.html

Let's add the DeprecationWarning.

It was originally planned to be removed in Python 4.0, but that was before we knew if 3.10 or 4.0 would come after 3.9:

'4.0' is a stand-in for 'sometime after 2.7.final', scheduled for Jan 2020.

#80480 (comment)

So as this is going into 3.12 3.13, let's target 3.14 3.15 3.16 for removal.

@hugovk hugovk added the stdlib Python modules in the Lib dir label Aug 7, 2022
@asedeno
Copy link

asedeno commented Aug 30, 2022

As a user of the 'u' array type, I'd like to see this postponed until a UCS4 'w' array type is in place to migrate to, as was proposed in #80480 (comment).

@smontanaro
Copy link
Contributor

(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.)

Looks like this was approved before @asedeno's comment. Can someone respond to the expressed concern? (It seems no 'w' code has been implemented yet.)

@hugovk
Copy link
Member Author

hugovk commented Nov 27, 2022

Thanks for the ping. I commented in the issue, let's continue there.

@hauntsaninja hauntsaninja marked this pull request as draft December 23, 2022 05:46
@arhadthedev arhadthedev added extension-modules C modules in the Modules dir and removed stdlib Python modules in the Lib dir labels May 5, 2023
@hugovk
Copy link
Member Author

hugovk commented Jun 4, 2023

Updated to target removal in 3.16, following addition of 'w' in #105242 and following the plan at #80480 (comment).

@hugovk hugovk marked this pull request as ready for review June 4, 2023 18:01
Lib/test/test_re.py Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.13.rst Show resolved Hide resolved
Modules/arraymodule.c Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Lib/test/test_buffer.py Outdated Show resolved Hide resolved
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left minor remarks on the doc. It's up to you to address them or ignore them ;-) Thanks for the updates.

Doc/whatsnew/3.13.rst Show resolved Hide resolved
@hugovk hugovk merged commit cc87948 into python:main Jun 11, 2023
@hugovk hugovk deleted the 80480-deprecate-array-u branch June 11, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-modules C modules in the Modules dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants