Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93044: No longer convert the database argument of sqlite3.connect() to bytes #93046

Merged
merged 1 commit into from
May 21, 2022
Merged

gh-93044: No longer convert the database argument of sqlite3.connect() to bytes #93046

merged 1 commit into from
May 21, 2022

Conversation

serhiy-storchaka
Copy link
Member

Just pass it to the factory as is.

@serhiy-storchaka
pythongh-93044: No longer convert the database argument of sqlite3.co…
19c77f5 
…nnect() to bytes

Just pass it to the factory as is.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.11 only security fixes labels May 21, 2022
@serhiy-storchaka serhiy-storchaka linked an issue May 21, 2022 that may be closed by this pull request
Unintentional changes in sqlite3.connect() #93044
Closed
@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 21, 2022 •
edited
Loading

I wonder if we should run this through the Django test suite as well; they've got a ton of sqlite3 tests there.

@felixxm, what do you think?

@serhiy-storchaka serhiy-storchaka merged commit 14c0d33 into python:main May 21, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 14c0d33016a967a98155f2e1615660e9328aef5d 3.11

@serhiy-storchaka serhiy-storchaka deleted the sqlite-connect-factory-database-arg branch May 21, 2022 11:35
@felixxm
Copy link
Contributor

felixxm commented May 21, 2022

I wonder if we should run this through the Django test suite as well; they've got a ton of sqlite3 tests there.

@felixxm, what do you think?

Will check.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 21, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 14c0d33016a967a98155f2e1615660e9328aef5d 3.11

@serhiy-storchaka serhiy-storchaka mentioned this pull request May 21, 2022
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 21, 2022
@bedevere-bot
Copy link

GH-93048 is a backport of this pull request to the 3.11 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 21, 2022
@serhiy-storchaka
[3.11] pythongh-93044: No longer convert the database argument of sql…
2caba36 
…ite3.connect() to bytes (pythonGH-93046)

Just pass it to the factory as is..
(cherry picked from commit 14c0d33)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@felixxm
Copy link
Contributor

felixxm commented May 21, 2022

Django checked ✔️ no issues.

@erlend-aasland
Copy link
Contributor

Django checked ✔️ no issues.

Thanks! Highly appreciated 🙏🏻

serhiy-storchaka added a commit that referenced this pull request May 21, 2022
@serhiy-storchaka
[3.11] gh-93044: No longer convert the database argument of sqlite3.c…
d9a48d2 
…onnect() to bytes (GH-93046) (GH-93048)

Just pass it to the factory as is.
(cherry picked from commit 14c0d33)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request May 21, 2022
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unintentional changes in sqlite3.connect()
5 participants
@serhiy-storchaka @erlend-aasland @miss-islington @felixxm @bedevere-bot