Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89289: Fix GHA annotation complaint for sqlite3 #92258

Merged
merged 1 commit into from
May 3, 2022
Merged

gh-89289: Fix GHA annotation complaint for sqlite3 #92258

merged 1 commit into from
May 3, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 3, 2022 •
edited
Loading

resolves #89289

@JelleZijlstra JelleZijlstra self-assigned this May 3, 2022
vstinner
vstinner approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest to change the commit message to something like:

gh-89289: Fix compiler warning in _sqlite/connection.c

GHA is just one way to see the warning.

@erlend-aasland
Copy link
Contributor Author

LGTM, but I suggest to change the commit message to something like:

Sure, feel free to do so when you merge :)

@vstinner vstinner merged commit d9ec553 into python:main May 3, 2022
@vstinner
Copy link
Member

vstinner commented May 3, 2022

Merged, thanks.

@erlend-aasland erlend-aasland deleted the fix-annotation branch May 3, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@vstinner vstinner vstinner approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sqlite3] cleanup and harden Connection.__init__
5 participants
@erlend-aasland @vstinner @carljm @JelleZijlstra @bedevere-bot