Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92223: Remove pre-Python 3.7 alternative #92224

Merged
merged 2 commits into from
May 5, 2022
Merged

gh-92223: Remove pre-Python 3.7 alternative #92224

merged 2 commits into from
May 5, 2022
+1 −16

Conversation

srittau
Copy link
Contributor

@srittau srittau commented May 3, 2022 •
edited by JelleZijlstra
Loading

@srittau srittau requested review from 1st1 and asvetlov as code owners May 3, 2022 11:51
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 3, 2022
@srittau
Copy link
Contributor Author

srittau commented May 3, 2022

Do docs-only changes like this need a NEWS entry?

@srittau srittau mentioned this pull request May 3, 2022
Closed
@srittau
Copy link
Contributor Author

srittau commented May 3, 2022

Also, we could keep the example, but without the ensure_future() alternative, but I'm not sure it's worth it for the remaining, rather trivial part.

@AlexWaygood
Copy link
Member

Do docs-only changes like this need a NEWS entry?

Nope :)

@AlexWaygood
Copy link
Member

We could probably also get rid of the "(requires 3.7+)" note at Line 23.

@srittau
Copy link
Contributor Author

srittau commented May 3, 2022

We could probably also get rid of the "(requires 3.7+)" note at Line 23.

Good catch, done.

@AlexWaygood
Copy link
Member

AlexWaygood commented May 3, 2022 •
edited
Loading

Also, we could keep the example, but without the ensure_future() alternative, but I'm not sure it's worth it for the remaining, rather trivial part.

There are lots of examples elsewhere in this document of how to use create_task, so personally I think it's fine to just ditch the example, as you've done.

@AlexWaygood AlexWaygood added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 3, 2022
@JelleZijlstra JelleZijlstra self-assigned this May 3, 2022
@JelleZijlstra JelleZijlstra merged commit d1b2e98 into python:main May 5, 2022
@miss-islington
Copy link
Contributor

Thanks @srittau for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92319 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 5, 2022
@bedevere-bot
Copy link

GH-92320 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2022
@srittau @miss-islington
pythongh-92223: Remove pre-Python 3.7 alternative in asyncio docs (py…
383abdd 
…thonGH-92224)

(cherry picked from commit d1b2e98)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
miss-islington added a commit that referenced this pull request May 5, 2022
@miss-islington @srittau
gh-92223: Remove pre-Python 3.7 alternative in asyncio docs (GH-92224)
bb2dcf1 
(cherry picked from commit d1b2e98)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
miss-islington added a commit that referenced this pull request May 5, 2022
@miss-islington @srittau
gh-92223: Remove pre-Python 3.7 alternative in asyncio docs (GH-92224)
d82a769 
(cherry picked from commit d1b2e98)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
@srittau srittau deleted the asyncio-task-doc branch May 5, 2022 07:39
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @srittau @hello-adam
pythongh-92223: Remove pre-Python 3.7 alternative in asyncio docs (py…
16795a8 
…thonGH-92224)

(cherry picked from commit d1b2e98)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@srittau @AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra @kumaraditya303