gh-89289: Harden sqlite3.Connection init #92214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure SQLite resources are freed if database open fails - Remove unneeded branches if init is aborted
erlend-aasland
commented
May 3, 2022
erlend-aasland
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f01c13a 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Comments on CI/buildbot run:
|
|
See the issue, and in particular #89289 (comment) for an explanation of parts of these changes. |
JelleZijlstra
approved these changes
May 3, 2022
|
Updated the branch to make sure the macOS failure really is a fluke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #89289