-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow the Exception in test_urllib2 test. Catch URLError, not OSError #918
Conversation
…n urllib.request module.
@orsenthil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @facundobatista, @Yhg1s and @loewis to be potential reviewers. |
Shouldn't the comment |
@serhiy-storchaka, it is removed: https://github.com/python/cpython/pull/918/files - are you referring to a comment at some other place? |
@@ -839,7 +838,7 @@ def test_file(self): | |||
try: | |||
h.file_open(req) | |||
# XXXX remove OSError when bug fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm referring to this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, it's right there in the context and still I missed it. Thanks for point out. I will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's removed now: #1020
Thank you for catching.
FileHandler catches OSError and raises them as URLError. Remove the reference to OSError in the tests.