Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29861: release references to multiprocessing Pool tasks #743

Merged
merged 4 commits into from
Mar 24, 2017

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 20, 2017

Release references to tasks, their arguments and their results as soon as they are finished, instead of keeping them alive until another task arrives.

Release references to tasks, their arguments and their results as soon
as they are finished, instead of keeping them alive until another task
arrives.
@pitrou pitrou requested a review from applio March 20, 2017 18:44
@pitrou pitrou added type-bug An unexpected behavior, bug, or error cherry-pick for 3.6 labels Mar 20, 2017
@pitrou
Copy link
Member Author

pitrou commented Mar 20, 2017

Note that, for some reason, the multiprocessing tests are excluded of the coverage runs, therefore codecov.io is complaining that my PR gets 0 coverage. @brettcannon might know more about this.

@brettcannon
Copy link
Member

The tests that are being skipped are due to the fact that they re-run a ton of tests that slows the whole coverage run down by a lot. It's possible I was overly aggressive or there's some flag to pass (or create) to minimize going overboard in the coverage report.

@pitrou
Copy link
Member Author

pitrou commented Mar 21, 2017

I think you could improve the coverage runtimes by using gcc instead of clang. gcc uses -Og which speeds up the debug builds a lot (see Travis-CI runtimes). Another possibility would be to use a non-debug interpreter.

@brettcannon
Copy link
Member

The coverage build is non-debug: https://github.com/python/cpython/blob/master/.travis.yml#L55. As for switching it over to gcc, I'm fine with that (but that's off-topic for this PR and can be discussed in python/core-workflow#46).

@pitrou
Copy link
Member Author

pitrou commented Mar 21, 2017

The coverage build is non-debug

Oh, I see. The test suite is slow because it doesn't run in parallel mode. Switching to gcc wouldn't change anything then.

@brettcannon
Copy link
Member

@pitrou There might be a way to set it up to run in parallel and still correct the proper information, but I have not tried to make that work.

@pitrou pitrou merged commit 8988945 into python:master Mar 24, 2017
pitrou added a commit to pitrou/cpython that referenced this pull request Mar 24, 2017
* bpo-29861: release references to multiprocessing Pool tasks

Release references to tasks, their arguments and their results as soon
as they are finished, instead of keeping them alive until another task
arrives.

* Comments in test

(cherry picked from commit 8988945)
pitrou added a commit to pitrou/cpython that referenced this pull request Mar 24, 2017
* bpo-29861: release references to multiprocessing Pool tasks

Release references to tasks, their arguments and their results as soon
as they are finished, instead of keeping them alive until another task
arrives.

* Comments in test

(cherry picked from commit 8988945)
pitrou added a commit that referenced this pull request Mar 24, 2017
)

* bpo-29861: release references to multiprocessing Pool tasks (#743)

* bpo-29861: release references to multiprocessing Pool tasks

Release references to tasks, their arguments and their results as soon
as they are finished, instead of keeping them alive until another task
arrives.

* Comments in test

(cherry picked from commit 8988945)

* Fix Misc/NEWS (hopefully)
pitrou added a commit that referenced this pull request Mar 24, 2017
)

* bpo-29861: release references to multiprocessing Pool tasks (#743)

* bpo-29861: release references to multiprocessing Pool tasks

Release references to tasks, their arguments and their results as soon
as they are finished, instead of keeping them alive until another task
arrives.

* Comments in test

(cherry picked from commit 8988945)

* Fix Misc/NEWS??
pitrou added a commit to pitrou/cpython that referenced this pull request Mar 24, 2017
* bpo-29861: release references to multiprocessing Pool tasks

Release references to tasks, their arguments and their results as soon
as they are finished, instead of keeping them alive until another task
arrives.

* Comments in test

(cherry picked from commit 8988945)
pitrou added a commit that referenced this pull request Mar 24, 2017
)

* bpo-29861: release references to multiprocessing Pool tasks (#743)

* bpo-29861: release references to multiprocessing Pool tasks

Release references to tasks, their arguments and their results as soon
as they are finished, instead of keeping them alive until another task
arrives.

* Comments in test

(cherry picked from commit 8988945)

* Fix Misc/NEWS ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants