Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Pull_request_template.md file #5841

Merged
merged 6 commits into from
Feb 23, 2018
Merged

Update the Pull_request_template.md file #5841

merged 6 commits into from
Feb 23, 2018

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Feb 23, 2018

Changed the template to be inside an <!-- --> tag.
Let contributors know that the PR title should include bpo number.

@brettcannon
Copy link
Member

The other option is to include a checklist that people can check off to make sure they have everything covered. Not sure if that's better than the comment since people will still need to change the body for the final commit, but it might help lead to people forgetting stuff less.

<!--
Thanks for your contribution!

Please take a quick look at those things down there. They're quite important.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please read this comment in its entirety. It's quite important."

@Mariatta
Copy link
Member Author

Thanks for the quick review!
Can I make the checklist inside the comment tag?
So we don't actually need to 'tick' each box.
Eventually the bots will tell them everything they need to know.

@brettcannon
Copy link
Member

I don't think there's a point to making checklist if people can't physically check stuff off, so don't worry about it.

@Mariatta
Copy link
Member Author

Ok. Let's try out this new PR template for now, we can think about the checklist later.

@Mariatta Mariatta merged commit 82ab13d into master Feb 23, 2018
@Mariatta Mariatta deleted the Mariatta-patch-1 branch February 23, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants