Add missing backslashes in PCbuild bat files #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6. |
|
Sorry, @zware, I could not cleanly backport this to |
|
Sorry, @zware, I could not cleanly backport this to |
zware
added a commit
to zware/cpython
that referenced
this pull request
Dec 30, 2017
(cherry picked from commit 6c6d3a4)
zware
added a commit
that referenced
this pull request
Dec 30, 2017
zware
added a commit
to zware/cpython
that referenced
this pull request
Dec 31, 2017
…ythonGH-5057) (cherry picked from commit 6c6d3a4). (cherry picked from commit fe90efd)
|
GH-5058 is a backport of this pull request to the 2.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on my Windows 8.1 build worker,
%~dp0doesn't contain a trailing backslash, so uses of%PCBUILD%must add it.