Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-28762: Revert last commit (now using Android Unified Headers) #4488

Merged
merged 3 commits into from
Nov 23, 2017
Merged

bpo-28762: Revert last commit (now using Android Unified Headers) #4488

merged 3 commits into from
Nov 23, 2017

Conversation

xdegaye
Copy link
Contributor

@xdegaye xdegaye commented Nov 21, 2017

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart the NEWS change.

.. section: Build

lockf() is available on Android API level 24, but the F_LOCK macro is not
defined in android-ndk-r13.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Python 3.7a1 has been released, I dislike the idea of modying the changelog. Please leave it as it is. Add a new NEWS entry if you want to document the change.

@xdegaye xdegaye merged commit 5ce1069 into python:master Nov 23, 2017
@xdegaye xdegaye deleted the bpo-28762 branch November 23, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants