bpo-29572: Update Windows build to OpenSSL 1.0.2k #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zware, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba and @ned-deily to be potential reviewers. |
Mariatta
reviewed
Mar 3, 2017
Misc/NEWS
Outdated
| @@ -806,6 +806,8 @@ Documentation | |||
| Build | |||
| ----- | |||
|
|
|||
| - Issue #29572: Update Windows build and OS X installers to use OpenSSL 1.0.2k. | |||
There was a problem hiding this comment.
I think the change here only reflect Windows build.
Is there going to be a separate PR for OS X?
There was a problem hiding this comment.
Yes, that's up to @ned-deily. I went ahead and copied the message from our 1.0.2j update assuming that it will be done anyway :)
There was a problem hiding this comment.
That's fine. The additional PR is coming. Although aren't we using bpo- stylings now in Misc/NEWS?
This was referenced Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_xmlrpcfails, but it did before the update as well, so I'm calling it good.