Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27541: Reprs of subclasses of some classes now contain actual type name. #3631

Merged
merged 1 commit into from
Sep 21, 2017
Merged

bpo-27541: Reprs of subclasses of some classes now contain actual type name. #3631

merged 1 commit into from
Sep 21, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 17, 2017 •
edited by bedevere-bot
Loading

Affected classes are bytearray, array, deque, defaultdict, count and repeat.

https://bugs.python.org/issue27541

rhettinger
rhettinger approved these changes Sep 17, 2017
View reviewed changes
Copy link
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only one I have misgivings about is itertools.count() doesn't seem to be meaningfully subclassable. But changing the repr for count doesn't have any negative effect, so +0 for changing it.

@serhiy-storchaka
bpo-27541: Reprs of subclasses of some classes now contain actual typ…
6e75a20 
…e name.

Affected classes are bytearray, array, deque, defaultdict, count and repeat.
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Sep 17, 2017 •
edited
Loading

Maybe make count and repeat not subclassable?

@serhiy-storchaka serhiy-storchaka merged commit b3a7796 into python:master Sep 21, 2017
@serhiy-storchaka serhiy-storchaka deleted the collections-repr-type-name branch September 21, 2017 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @rhettinger @Mariatta @the-knights-who-say-ni @bedevere-bot