Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in http://bugs.python.org/issue31338 the idea to implement a macro called
Py_UNREACHABLE()
was proposed. This would be used in cases where you'd be tempted to use anassert(0)
orabort()
, i.e. for code paths you do not expect will ever be reached.Using
Py_UNREACHABLE()
has a few advantages:__FILE__
and__LINE__
, etc.I've changed the examples described in bpo-31338, but may not have gotten them all.
For now, this is defined strictly as
abort()
which is the simplest thing that make the common compilers happy.I've also added some documentation about
Py_UNREACHABLE()
and a few other macros inpymacros.h
.https://bugs.python.org/issue31338