Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-26175: Fix SpooledTemporaryFile IOBase abstract #3249

Closed
wants to merge 13 commits into from
Closed

bpo-26175: Fix SpooledTemporaryFile IOBase abstract #3249

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
83d6152
Fix SpooledTemporaryFile IOBase abstract
GFernie Aug 30, 2017
3b69baa
Add news entry for bpo-26175 patch
GFernie Aug 30, 2017
753b4fb
Update 2017-08-30-23-14-17.bpo-26175.GOaj9y.rst
merwok Sep 20, 2017
a70113e
Make SpooledTemporaryFile subclass IOBase
GFernie Sep 30, 2017
fb28362
Refactor tests to more reliably test abstract
GFernie Sep 30, 2017
bc9d0a9
Return new absolute position from underlying file on seek
GFernie Sep 9, 2018
b588dec
Do nothing on __del__
GFernie Sep 9, 2018
ab49dd1
Return new file size from underlying file on truncate
GFernie Sep 9, 2018
4251b21
Merge remote-tracking branch 'origin/master' into bpo-26175_fix-Spool…
GFernie Oct 30, 2019
19f4c08
Add versionchanged tag
GFernie Oct 30, 2019
4519b9c
Use :class: instead of :py:data:
GFernie Oct 30, 2019
554aad6
Revert "Do nothing on __del__"
GFernie Nov 23, 2019
be094b3
Add test for rolled file finalisation
GFernie Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor tests to more reliably test abstract
  • Loading branch information
@GFernie
GFernie committed Sep 30, 2017
commit fb283621685da73771256d8eb51dabf19fe71378
41 changes: 14 additions & 27 deletions Lib/test/test_tempfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,34 +982,21 @@ def test_basic(self):
f = self.do_create(max_size=100, pre="a", suf=".txt")
self.assertFalse(f._rolled)

def test_iobase_abstract(self):
# SpooledTemporaryFile should implement the IOBase abstract
iobase_abstract = (
'close',
'closed',
'fileno',
'flush',
'isatty',
'read',
'readable',
'readinto',
'readline',
'readlines',
'seek',
'seekable',
'tell',
'truncate',
'write',
'writable',
'writelines',
'__del__',
def test_is_iobase(self):
# SpooledTemporaryFile should implement io.IOBase
self.assertIsInstance(self.do_create(), io.IOBase)

def test_iobase_interface(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are not very interesting. It would be better to test the methods operate properly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It literally delegates everything to the underlying file.

The existing tests should cover the behaviors. The new behaviors are intended to flesh out the API so that SpooledTemporaryFile, and these tests seem to cover that.

# SpooledTemporaryFile should implement the io.IOBase interface.
# IOBase does not declare read(), readinto(), or write(), but
# they should be considered part of the interface.
iobase_abstract = {'read', 'readinto', 'write'}
spooledtempfile_abstract = set(dir(tempfile.SpooledTemporaryFile))
missing_attributes = iobase_abstract - spooledtempfile_abstract
self.assertFalse(
missing_attributes,
'io.IOBase attributes missing from SpooledTemporaryFile'
)
f = self.do_create()
for attribute in iobase_abstract:
self.assertTrue(
hasattr(f, attribute),
'{} attribute missing'.format(attribute)
)

def test_del_on_close(self):
# A SpooledTemporaryFile is deleted when closed
Expand Down