Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46927: Include the type's name in the error message for subscripting non-generic types #31694

Merged
merged 2 commits into from
Mar 5, 2022
Merged

bpo-46927: Include the type's name in the error message for subscripting non-generic types #31694

merged 2 commits into from
Mar 5, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 5, 2022 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 5, 2022
@serhiy-storchaka serhiy-storchaka changed the title bpo-46927: Include the type's name in the error message for subscribing non-generic types bpo-46927: Include the type's name in the error message for subscripting non-generic types Mar 5, 2022
@serhiy-storchaka @kumaraditya303
Update Misc/NEWS.d/next/Core and Builtins/2022-03-05-12-23-58.bpo-469…
79f9eb9 
…27.URbHBi.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303
kumaraditya303 approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit ab9301a into python:main Mar 5, 2022
@serhiy-storchaka serhiy-storchaka deleted the subscribe-non-generic-type-error branch March 5, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @iritkatriel @kumaraditya303 @the-knights-who-say-ni @bedevere-bot