bpo-46126: Disable 'descriptions' when running tests internally. #30194

jaraco · 2021-12-19T03:24:03Z

https://bugs.python.org/issue46126

Automerge-Triggered-By: GH:jaraco

jaraco · 2021-12-24T19:26:10Z

Hey Victor. Github thinks you might be a good reviewer, so I've requested your review. Please take a look, or re-assign to someone else (Łukasz maybe), or suggest another avenue. Thanks.

vstinner

LGTM.

Displaying test method docstrings caused me many practical issues when analyzing buildbot results. For example, it's harder to apply a regular expression to convert a test output to a list of test method which have been executed. I need to do that to re-run the same test methods, usually to bisect a reference leak.

@pablogsal: do you want to also have a look into this regrtest output change?

pablogsal

LGTM

Thanks for the PR @jaraco !

bedevere-bot · 2022-01-22T19:12:52Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 LTO 3.x has failed when building commit a941e59.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/507/builds/1408) and take a look at the build logs.
Check if the failure is related to this commit (a941e59) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/507/builds/1408

Failed tests:

test_shutil
test_zipfile

Failed subtests:

test_append_to_concatenated_zip_file - test.test_zipfile.StoredTestsWithSourceFile
test_regular_copy - test.test_shutil.TestZeroCopySendfile
test_small_chunks - test.test_shutil.TestZeroCopySendfile
test_big_chunk - test.test_shutil.TestZeroCopySendfile
test_non_regular_file_src - test.test_shutil.TestZeroCopySendfile
test_file2file_not_supported - test.test_shutil.TestZeroCopySendfile
setUpClass - test.test_shutil.TestZeroCopySendfile
test_cant_get_size - test.test_shutil.TestZeroCopySendfile

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

416 tests OK.

10 slowest tests:

test_peg_generator: 5 min 32 sec
test_mailbox: 4 min 15 sec
test_concurrent_futures: 2 min 41 sec
test_gdb: 2 min 10 sec
test_multiprocessing_spawn: 1 min 46 sec
test_sqlite3: 1 min 44 sec
test_dbm: 1 min 42 sec
test_shelve: 1 min 40 sec
test_multiprocessing_forkserver: 1 min 14 sec
test_multiprocessing_fork: 1 min 5 sec

2 tests failed:
test_shutil test_zipfile

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_smtpnet
test_ssl test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

2 re-run tests:
test_shutil test_zipfile

Total duration: 7 min 43 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2369, in get_files
    yield (src, dst)
    ^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2384, in test_regular_copy
    self.zerocopy_fun(src, dst)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2450, in zerocopy_fun
    return shutil._fastcopy_sendfile(fsrc, fdst)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 158, in _fastcopy_sendfile
    raise err from None
    ^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 144, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device: '@test_30061_tmpæ' -> '@test_30061_tmpæ2'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2369, in get_files
    yield (src, dst)
    ^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2520, in test_big_chunk
    shutil._fastcopy_sendfile(src, dst)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 158, in _fastcopy_sendfile
    raise err from None
    ^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 144, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device: '@test_30061_tmpæ' -> '@test_30061_tmpæ2'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_zipfile.py", line 533, in test_append_to_concatenated_zip_file
    f.write(data)
    ^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2457, in test_non_regular_file_src
    shutil.copyfileobj(src, dst)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 200, in copyfileobj
    fdst_write(buf)
    ^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2369, in get_files
    yield (src, dst)
    ^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2494, in test_cant_get_size
    shutil._fastcopy_sendfile(src, dst)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 158, in _fastcopy_sendfile
    raise err from None
    ^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 144, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device: '@test_30061_tmpæ' -> '@test_30061_tmpæ2'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2558, in test_file2file_not_supported
    shutil.copyfile(TESTFN, TESTFN2)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 279, in copyfile
    copyfileobj(fsrc, fdst)
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 200, in copyfileobj
    fdst_write(buf)
    ^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2369, in get_files
    yield (src, dst)
    ^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2507, in test_small_chunks
    shutil._fastcopy_sendfile(src, dst)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 158, in _fastcopy_sendfile
    raise err from None
    ^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/shutil.py", line 144, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device: '@test_30061_tmpæ' -> '@test_30061_tmpæ2'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_931504f9'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_6108b6c6'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 2353, in setUpClass
    write_test_file(TESTFN, cls.FILESIZE)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_shutil.py", line 98, in write_test_file
    f.write(chunk)
    ^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_9cb40663'

jaraco · 2022-01-22T19:57:31Z

Test failures are "no space left on device". Seems to be a buildbot issue and not related to the patch.

…ly. (GH-30194)" This reverts commit a941e59.

…32128) This reverts commit a941e59 (GH-30194). Automerge-Triggered-By: GH:jaraco

the-knights-who-say-ni added the CLA signed label Dec 19, 2021

bedevere-bot added the awaiting core review label Dec 19, 2021

bpo-46126: Disable 'descriptions' when running tests internally.

7bff1c3

jaraco force-pushed the bpo-46126/bad-error-message branch from 1e54781 to 7bff1c3 Compare December 19, 2021 03:25

jaraco requested a review from vstinner December 24, 2021 19:24

Makmudik approved these changes Dec 24, 2021

View reviewed changes

vstinner approved these changes Jan 6, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jan 6, 2022

pablogsal approved these changes Jan 6, 2022

View reviewed changes

jaraco added the 🤖 automerge label Jan 22, 2022

miss-islington merged commit a941e59 into main Jan 22, 2022

miss-islington deleted the bpo-46126/bad-error-message branch January 22, 2022 18:49

bedevere-bot removed the awaiting merge label Jan 22, 2022

jaraco added a commit that referenced this pull request Mar 26, 2022

Revert "bpo-46126: Disable 'descriptions' when running tests internal…

3e93af0

…ly. (GH-30194)" This reverts commit a941e59.

jaraco mentioned this pull request Mar 26, 2022

bpo-46126: Restore 'descriptions' when running tests internally. #32128

Merged

miss-islington pushed a commit that referenced this pull request Apr 3, 2022

bpo-46126: Restore 'descriptions' when running tests internally. (GH-…

84acb5c

…32128) This reverts commit a941e59 (GH-30194). Automerge-Triggered-By: GH:jaraco

jaraco mentioned this pull request Apr 10, 2022

Unittest output drives developers to avoid docstrings #90284

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-46126: Disable 'descriptions' when running tests internally. #30194

bpo-46126: Disable 'descriptions' when running tests internally. #30194

jaraco commented Dec 19, 2021 •

edited by miss-islington

Loading

jaraco commented Dec 24, 2021

vstinner left a comment

pablogsal left a comment

bedevere-bot commented Jan 22, 2022

jaraco commented Jan 22, 2022

bpo-46126: Disable 'descriptions' when running tests internally. #30194

bpo-46126: Disable 'descriptions' when running tests internally. #30194

Conversation

jaraco commented Dec 19, 2021 • edited by miss-islington Loading

jaraco commented Dec 24, 2021

vstinner left a comment

Choose a reason for hiding this comment

pablogsal left a comment

Choose a reason for hiding this comment

bedevere-bot commented Jan 22, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

jaraco commented Jan 22, 2022

jaraco commented Dec 19, 2021 •

edited by miss-islington

Loading