-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46124: Update zoneinfo to rely on importlib.resources traversable API. #30190
Conversation
d7b5cfc
to
9473c00
Compare
Misc/NEWS.d/next/Library/2021-12-18-18-41-30.bpo-46124.ESPrb7.rst
Outdated
Show resolved
Hide resolved
When you're done making the requested changes, leave the comment: |
I have made the requested changes; please review again. |
1 similar comment
I have made the requested changes; please review again. |
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
I don't understand the CI failures. Bedevere seems to think this is a PR against a maintenance branch (it's not) and that it's got no issue number (though it does have one). Maybe rebase and see if that fixes it? |
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>
07481e5
to
dd4c246
Compare
@jaraco: Status check is done, and it's a success ✅ . |
1 similar comment
@jaraco: Status check is done, and it's a success ✅ . |
Sorry, I can't merge this PR. Reason: |
1 similar comment
Sorry, I can't merge this PR. Reason: |
Good call. Bedevere seems happy with it now, so I expect it to merge automatically once tests pass. |
@jaraco: Status check is done, and it's a failure ❌ . |
@jaraco: Status check is done, and it's a success ✅ . |
|
At first blush, that error looks to be a false positive. I can't tell if there's an error or solely a "altered execution environment" failure. It's conceivable that something about test_asyncio is accessing the zoneinfo module and triggering resource issues in how zoneinfo returns open file resources. But I don't see anything of the sort in the tracebacks or test names. Worse, test_asyncio is a package and not a module, so the locus of the failure is diffuse. Still, I confirmed that |
Hmm. Many tests prior to the commit all pass, suggesting this commit was highly unlucky or is in fact implicated. Still awaiting a result for after. I do see that |
https://bugs.python.org/issue46124
Automerge-Triggered-By: GH:jaraco