Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40915: Fix a 32bit compiler warning in mmapmodule.c on Windows #30175

Merged
merged 1 commit into from
Dec 18, 2021
Merged

bpo-40915: Fix a 32bit compiler warning in mmapmodule.c on Windows #30175

merged 1 commit into from
Dec 18, 2021

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Dec 17, 2021

MSVC(x86) shows the following warning at mmap_resize_method() when building 3.11.

mmapmodule.c(539,58): warning C4244: '=':
conversion from 'LONGLONG' to 'Py_ssize_t', possible loss of data

https://bugs.python.org/issue40915

@neonene neonene changed the title bpo-40915: Fix a compiler warning in mmapmodule.c on Windows(32bit) bpo-40915: Fix a 32bit compiler warning in mmapmodule.c on Windows Dec 17, 2021
@zooba zooba added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Dec 18, 2021
@zooba zooba merged commit 6214caa into python:main Dec 18, 2021
@miss-islington
Copy link
Contributor

Thanks @neonene for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @neonene and @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6214caafbe66e34e84c1809abf0b7aab6791956b 3.10

@miss-islington
Copy link
Contributor

Sorry @neonene and @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6214caafbe66e34e84c1809abf0b7aab6791956b 3.9

@zooba
Copy link
Member

zooba commented Dec 18, 2021

I don't have time right now to do backports, so if someone else wants to go right ahead. Remember to put [3.10] and [3.9] in the title of the PR

@neonene
Copy link
Contributor Author

neonene commented Dec 18, 2021

Only 3.11 changed mmapmodule.c and emits the warning.

@AlexWaygood AlexWaygood removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Dec 18, 2021
@neonene
Copy link
Contributor Author

neonene commented Dec 18, 2021

Thanks @zooba and @AlexWaygood for the help.

@neonene neonene deleted the bpo-40915 branch December 18, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants