Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44874: deprecate Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END #27693

Merged
merged 6 commits into from
Aug 18, 2021
Merged

bpo-44874: deprecate Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END #27693

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6772bdf
bpo-44874: deprecate Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END
iritkatriel Aug 9, 2021
62d64e7
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 9, 2021
d4de5cd
add compiler warning
iritkatriel Aug 17, 2021
f58b627
add migration instructions to news file
iritkatriel Aug 18, 2021
dc5cd34
Increase example readability
ambv Aug 18, 2021
9d2d76d
Move porting instructions to What's New in Python 3.11
ambv Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Increase example readability 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@ambv @vstinner
ambv and vstinner committed Aug 18, 2021
commit dc5cd3422ff94ae36ccc8f7e3177a7af578fe81c
8 changes: 4 additions & 4 deletions Misc/NEWS.d/next/Core and Builtins/2021-08-09-19-05-20.bpo-44874.oOcfU4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ can define the following macros and use them throughout
the code (credit: these were copied from the ``mypy`` codebase)::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like mypy is released under the MIT license: https://github.com/python/mypy/blob/master/LICENSE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this impact the example?


#if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 8
#define CPy_TRASHCAN_BEGIN(op, dealloc) Py_TRASHCAN_BEGIN(op, dealloc)
#define CPy_TRASHCAN_END(op) Py_TRASHCAN_END
# define CPy_TRASHCAN_BEGIN(op, dealloc) Py_TRASHCAN_BEGIN(op, dealloc)
# define CPy_TRASHCAN_END(op) Py_TRASHCAN_END
#else
#define CPy_TRASHCAN_BEGIN(op, dealloc) Py_TRASHCAN_SAFE_BEGIN(op)
#define CPy_TRASHCAN_END(op) Py_TRASHCAN_SAFE_END(op)
# define CPy_TRASHCAN_BEGIN(op, dealloc) Py_TRASHCAN_SAFE_BEGIN(op)
# define CPy_TRASHCAN_END(op) Py_TRASHCAN_SAFE_END(op)
#endif