Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43795: Mark PyCodec_Unregister as a function, not data, in stable ABI #25920

Merged
merged 2 commits into from
May 5, 2021
Merged

bpo-43795: Mark PyCodec_Unregister as a function, not data, in stable ABI #25920

merged 2 commits into from
May 5, 2021

Conversation

encukou
Copy link
Member

@encukou encukou commented May 5, 2021 •
edited by bedevere-bot
Loading

@encukou encukou requested a review from a team as a code owner May 5, 2021 16:32
orsenthil
orsenthil approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou removed the skip news label May 5, 2021
@encukou encukou merged commit cf86996 into python:main May 5, 2021
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-25925 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 5, 2021
@encukou encukou deleted the pep652-PyCodec_Unregister branch May 5, 2021 17:34
@encukou
Copy link
Member Author

encukou commented May 5, 2021

Thanks for the review!

miss-islington added a commit that referenced this pull request May 5, 2021
@miss-islington @encukou
bpo-43795: Mark PyCodec_Unregister as a function, not data, in stable…
8f3ef45 
… ABI (GH-25920)

(cherry picked from commit cf86996)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@encukou encukou mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@encukou @miss-islington @bedevere-bot @orsenthil @the-knights-who-say-ni