bpo-43827: Fixed abc conflicts with __init_subclass__

[vladhoi]

https://bugs.python.org/issue43827

[ypankovych]

LGTM

[vladhoi]

Hi @serhiy-storchaka
I see that you committed to abc module, could you please review this pr? 🙂

[pganssle]

This seems in line with what @serhiy-storchaka was trying to do in GH-13700, though I'm not confident that we can consider this to be a backwards-compatible change. Even though _py_abc has had this same signature for a while, I think most people get this version, not the other one, so it's possible this will break someone passing one of these by keyword. If we're going to change it, it should probably be 3.11+ and not backported.

Also, this needs at least one test. Presumably the MWE detailed in the BPO issue can be refactored into a test.

[pganssle]

This is not really enough context for someone to understand what is changing just from reading the changelog. Something more like this would be better:

"All positional-or-keyword parameters to ABCMeta.__new__ are now positional-only to avoid conflicts with keyword arguments to be passed to __init_subclass__."

I am not super confident that that's the only thing that ABCMeta's **kwargs is used for, so if it's used for other stuff, more general wording would be appropriate.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[vladhoi]

I have made the requested changes; please review again

[bedevere-bot]

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

[ypankovych]

@pganssle can you take a look, please?

[ypankovych]

@pganssle are you there?

[vladhoi]

Hi @pganssle
Could you please re-review when you have a chance?

[cpython-cla-bot]

All commit authors signed the Contributor License Agreement.

[JelleZijlstra]

Thanks, looks good! Unfortunately you'll have to re-sign the CLA under the new (much simpler) process.

[JelleZijlstra]

Thanks for your changes! We still need the CLA to be signed.

[serhiy-storchaka]

LGTM.

[vladhoi]

Hi @JelleZijlstra @serhiy-storchaka

Thanks for the review.
Unfortunately, I am not able to sign the cla, because the email provided by the bot is not correct and I don't have access to it. I tried to commit from the correct account, but it didn't help. Can I somehow resolve this issue and sign cla manually?

Thanks for your changes! We still need the CLA to be signed.

[JelleZijlstra]

I'd recommend you set your local git config to the right email address, then squash the commits on this branch and force-push the new commit.

[vladhoi]

@JelleZijlstra looks like it didn't help. Should close this pr and create a new one and ping you there?

[JelleZijlstra]

Sure, that's worth trying.

[vladhoi]

Hi @JelleZijlstra
I fixed the issue with the cla, it is now signed.
The pr is ready to be merged.
Thanks