Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42357: Fix wrong availability for signal.SIGCHLD #23285

Merged
merged 1 commit into from
Nov 20, 2020
Merged

bpo-42357: Fix wrong availability for signal.SIGCHLD #23285

merged 1 commit into from
Nov 20, 2020

Conversation

myzhang1029
Copy link
Contributor

@myzhang1029 myzhang1029 commented Nov 14, 2020 •
edited by bedevere-bot
Loading

I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.

https://bugs.python.org/issue42357

@myzhang1029
Fix wrong availability for signal.SIGCHLD
9738f9f 
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@myzhang1029

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 14, 2020
@asvetlov asvetlov added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes skip news labels Nov 20, 2020
@asvetlov asvetlov merged commit 4c24b08 into python:master Nov 20, 2020
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @myzhang1029 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23425 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 20, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2020
@myzhang1029 @miss-islington
Fix wrong availability for signal.SIGCHLD (pythonGH-23285)
5e3a6e8 
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2020
@myzhang1029 @miss-islington
Fix wrong availability for signal.SIGCHLD (pythonGH-23285)
78d7e5f 
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
@bedevere-bot
Copy link

GH-23426 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Nov 20, 2020
asvetlov pushed a commit that referenced this pull request Nov 21, 2020
@miss-islington @myzhang1029
Fix wrong availability for signal.SIGCHLD (GH-23285) (#23426)
7e9bf4e 
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
asvetlov pushed a commit that referenced this pull request Nov 21, 2020
@miss-islington @myzhang1029
Fix wrong availability for signal.SIGCHLD (GH-23285) (#23425)
3b5b1c8 
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@myzhang1029 @adorilson
Fix wrong availability for signal.SIGCHLD (python#23285)
2e8ba85 
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@myzhang1029 @the-knights-who-say-ni @bedevere-bot @miss-islington @asvetlov