Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Remove no longer valid note on platform.win32_ver #22005

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

andresdelfino
Copy link
Contributor

The comment no longer applies since v3.5.1rc1: b9f4fea

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Aug 29, 2020
@andresdelfino andresdelfino changed the title [doc] Remove outdated comment in platform [doc] Remove outdated comment on platform.win32_ver Oct 21, 2020
@andresdelfino
Copy link
Contributor Author

@zooba as you commited the change that made this obsolete, perhaps you can verify? b9f4fea

@andresdelfino
Copy link
Contributor Author

@mhammond perhaps you can confirm? :)

@mhammond
Copy link
Contributor

mhammond commented Nov 2, 2020

That change looks correct to me.

@andresdelfino andresdelfino changed the title [doc] Remove outdated comment on platform.win32_ver [doc] Remove no longer valid note on platform.win32_ver Nov 3, 2020
@zooba zooba added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Nov 6, 2020
@zooba
Copy link
Member

zooba commented Nov 6, 2020

Thanks for this! (Sorry I didn't see it, GitHub notifications are a mess...)

@zooba zooba merged commit 7c01f15 into python:master Nov 6, 2020
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23183 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-23184 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Nov 6, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2020
…2005)

(cherry picked from commit 7c01f15)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2020
…2005)

(cherry picked from commit 7c01f15)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the remove_outdated_win32 branch November 6, 2020 19:00
miss-islington added a commit that referenced this pull request Nov 6, 2020
(cherry picked from commit 7c01f15)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Nov 7, 2020
…lots1

* origin/master: (80 commits)
  bpo-42282: Fold constants inside named expressions (pythonGH-23190)
  bpo-41028: Doc: Move switchers to docsbuild-scripts. (pythonGH-20969)
  bpo-42133: update parts of the stdlib to fall back to `__spec__.loader` when `__loader__` is missing (python#22929)
  Remove outdated reference to pywin32 from platform module (pythonGH-22005)
  bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (pythonGH-23123)
  Minor grammar edits for the descriptor howto guide (GH-python#23175)
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  ...
miss-islington added a commit that referenced this pull request Nov 17, 2020
…2005) (GH-23184)

(cherry picked from commit 7c01f15)


Co-authored-by: Andre Delfino <adelfino@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants