-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40275: Remove test helpers import in test.support #21771
Conversation
1702b89
to
04d8390
Compare
04d8390
to
6cda06a
Compare
@vstinner Hi, victor. It's all done. |
Well done, thanks @shihai1991! |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
oh, looks like some testcases failed. |
|
|
|
|
#21785 will fix the buildbot's error report. |
|
|
|
This PR has broken a considerable amount of build bots, so we would need to revert it if is not fixed in 24 hours |
Whops, sorry I just saw that this is being fixed here #21785, apologies then! |
Since tests passed on Linux and Windows in the pre-commit CI, I was confident to merge the change. I didn't expect this amount of buildbot failures! I should have use the buildbot label :-/ Hopefully, it should be now fixed by #21785. |
Summary: The alias was removed in python/cpython#21771. Reviewed By: tekknolagi Differential Revision: D38540106 fbshipit-source-id: 3823c48
https://bugs.python.org/issue40275