Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40275: Use new test.support helper submodules in tests #21743

Merged
merged 1 commit into from
Aug 6, 2020
Merged

bpo-40275: Use new test.support helper submodules in tests #21743

merged 1 commit into from
Aug 6, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Aug 5, 2020 •
edited
Loading

Use test helpers in the following test cases:

  • test_dbm_gnu
  • test_faulthandler
  • test_grp
  • test_dbm_gnu
  • test_faulthandler
  • test_grp
  • test_http_cookiejar
  • test_httpservers
  • test_import
  • test_ntpath
  • test_site
  • test_socketserver
  • test_statistics
  • test_tabnanny
  • test_tcl
  • test_md5sum
  • test_turtle
  • test_urllib2net
  • test_urllibnet
  • test_webbrowser
  • test_winsound
  • test_tkinter

https://bugs.python.org/issue40275

@shihai1991 shihai1991 force-pushed the bpo_40275_helper_replace_17 branch 2 times, most recently from 1abdbff to cc5a557 Compare August 5, 2020 15:06
@shihai1991 shihai1991 requested a review from tiran as a code owner August 6, 2020 04:35
@shihai1991 shihai1991 changed the title [WIP] Remove import test helper in test.support bpo-40275: Use new test.support helper submodules in tests Aug 6, 2020
@shihai1991
Copy link
Member Author

cc @vstinner

@vstinner
Copy link
Member

vstinner commented Aug 6, 2020

@shihai1991: How many remaining tests need to be patched? Do you have an estimation?

@vstinner vstinner merged commit 79bb2c9 into python:master Aug 6, 2020
@shihai1991
Copy link
Member Author

@shihai1991: How many remaining tests need to be patched? Do you have an estimation?

I have ported all tests what I can test in my centos vm. To some testcases which runs in windows and macos I depend ci gate to estimate.
I estimate it's between 5 to 8(not too exact)

@vstinner
Copy link
Member

vstinner commented Aug 6, 2020

I estimate it's between 5 to 8(not too exact)

That's great!

I have ported all tests what I can test in my centos vm. To some testcases which runs in windows and macos I depend ci gate to estimate.

You can write a test/WIP PR which removes aliases in test.support and see which tests fail.

@shihai1991
Copy link
Member Author

You can write a test/WIP PR which removes aliases in test.support and see which tests fail.

yep. I have already did this ; )

shihai1991 added a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@shihai1991
bpo-40275: Use new test.support helper submodules in tests (pythonGH-…
5b95d6e 
…21743)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@shihai1991
bpo-40275: Use new test.support helper submodules in tests (pythonGH-…
7424e5d 
…21743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot