-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-41482: Fix error in ipaddress.IPv4Network docstring #21736
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! As soon as the CLA is signed, I'll merge it.
I signed one of those on 2015/7/22, I think it was for a contribution I
made to Jython.
https://secure.echosign.com/public/viewAgreement?tsid=2AAABLblqZhCG5ON_GnB9N3pKGKQ32GfLmTCR1iGIlLOZHnHvN5O9DuEhpjurvcGHDSbJLVX6aLw*&
…On Wed, Aug 5, 2020 at 4:02 AM Eric V. Smith ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for catching this! As soon as the CLA is signed, I'll merge it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21736 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI47BRUFOYKUPBKXY2FQ23R7EGYNANCNFSM4PUX3Y6A>
.
|
I don't know what it takes to get this rectified. Can you check https://check-python-cla.herokuapp.com/ ? Or look at https://devguide.python.org/pullrequest/#licensing ? On the other hand, this change is trivial. But I think it would be good to get it cleared up. Your next contribution might not be so simple. |
Okay, I think it may be fixed now.
…On Wed, Aug 5, 2020 at 12:29 PM Eric V. Smith ***@***.***> wrote:
I don't know what it takes to get this rectified. Can you check
https://check-python-cla.herokuapp.com/ ? Or look at
https://devguide.python.org/pullrequest/#licensing ?
On the other hand, this change is trivial. But I think it would be good to
get it cleared up. Your next contribution might not be so simple.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21736 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI47BQLUR72W3GLHEFLBM3R7GCHTANCNFSM4PUX3Y6A>
.
|
Thanks @ericfrederich for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Sorry @ericfrederich and @ericvsmith, I had trouble checking out the |
GH-21746 is a backport of this pull request to the 3.8 branch. |
Thanks, @ericfrederich! |
(cherry picked from commit 52f9842) Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com>
Thanks @ericfrederich for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
(cherry picked from commit 52f9842) Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com>
GH-21747 is a backport of this pull request to the 3.9 branch. |
I think I did this right.
https://bugs.python.org/issue41482