Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41482: Fix error in ipaddress.IPv4Network docstring #21736

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

ericfrederich
Copy link
Contributor

@ericfrederich ericfrederich commented Aug 4, 2020

I think I did this right.

https://bugs.python.org/issue41482

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@ericfrederich

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! As soon as the CLA is signed, I'll merge it.

@ericvsmith ericvsmith self-assigned this Aug 5, 2020
@ericvsmith ericvsmith added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Aug 5, 2020
@ericfrederich
Copy link
Contributor Author

ericfrederich commented Aug 5, 2020 via email

@ericvsmith
Copy link
Member

I don't know what it takes to get this rectified. Can you check https://check-python-cla.herokuapp.com/ ? Or look at https://devguide.python.org/pullrequest/#licensing ?

On the other hand, this change is trivial. But I think it would be good to get it cleared up. Your next contribution might not be so simple.

@ericfrederich
Copy link
Contributor Author

ericfrederich commented Aug 5, 2020 via email

@ericvsmith ericvsmith merged commit 52f9842 into python:master Aug 5, 2020
@miss-islington
Copy link
Contributor

Thanks @ericfrederich for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @ericfrederich and @ericvsmith, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 52f98424a55e14f05dfa7483cc0faf634a61c9ff 3.9

@bedevere-bot
Copy link

GH-21746 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Aug 5, 2020
@ericvsmith
Copy link
Member

Thanks, @ericfrederich!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2020
(cherry picked from commit 52f9842)

Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com>
ericvsmith pushed a commit to ericvsmith/cpython that referenced this pull request Aug 5, 2020
…GH-21736)

(cherry picked from commit 52f9842)

Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com>
@terryjreedy terryjreedy added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Aug 5, 2020
@miss-islington
Copy link
Contributor

Thanks @ericfrederich for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2020
(cherry picked from commit 52f9842)

Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com>
@bedevere-bot
Copy link

GH-21747 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 5, 2020
miss-islington added a commit that referenced this pull request Aug 5, 2020
(cherry picked from commit 52f9842)

Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com>
miss-islington added a commit that referenced this pull request Aug 5, 2020
(cherry picked from commit 52f9842)

Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants