Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41384: fix .keys()[0] in tkinter #21601

Merged
merged 5 commits into from
Jul 27, 2020
Merged

bpo-41384: fix .keys()[0] in tkinter #21601

merged 5 commits into from
Jul 27, 2020

Conversation

Akuli
Copy link
Contributor

@Akuli Akuli commented Jul 23, 2020 •
edited by bedevere-bot
Loading

not sure if this needs bugs.python.org number or not

https://bugs.python.org/issue41384

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Akuli

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella
Copy link
Contributor

Yes, please open an issue on the bug tracker. Thank you!

@Akuli Akuli changed the title fix .keys()[0] in tkinter bpo-41384: fix .keys()[0] in tkinter Jul 24, 2020
@Akuli
Copy link
Contributor Author

Akuli commented Jul 24, 2020

do I really need to write my home address to an agreement in order to create a small bug fix pull request?

@tirkarthi
Copy link
Member

Code changes required CLA. Though the fix is trivial I guess this is a bugfix and would require a CLA and NEWS entry.

@Akuli
Copy link
Contributor Author

Akuli commented Jul 24, 2020

What should I do if I really don't want to sign the CLA? I don't think this bug actually bothers anyone because getting the wrong kind of error isn't too bad, not many people are using tkinter and not many tkinter users are using OptionMenu.

@Akuli @serhiy-storchaka
delete unnecessary .keys()
b24f881 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
serhiy-storchaka approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Akuli @terryjreedy
delete unnecessary values of OptionMenu
038919a 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy
Copy link
Member

Why would be your objection to signing the CLA?

@Akuli
Copy link
Contributor Author

Akuli commented Jul 26, 2020

I don't want to associate my github user with my home address. Why do I need to tell you (or Adobe or whoever sees the signed CLA) where I live in order to contribute a small bugfix?

@serhiy-storchaka
Copy link
Member

I think this change does not require signing the CLA. It is trivial enough.

@terryjreedy
Copy link
Member

Akuli, PSF does not have the resources that IBM and Google did to fight the Unix and Java API lawsuits. So we try to exercise 'due diligence'.

Having done so, I think*, I will merge this PR. 2to3 should have wrapped kwargs.keys() with list(), and that would have worked, but using iter is the documented way to access an arbitrary key. The code fix is too trivial for copyright. The added test is marginal, but it follows a template and you included my suggestion.

  • If you had said, "Because I wrote this at work" or "I disagree with the CLA", I would have replied "Thank you, but...", closed this, and written a new PR with the alternate fix.

@terryjreedy terryjreedy added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Jul 27, 2020
@terryjreedy terryjreedy merged commit f1d40f9 into python:master Jul 27, 2020
@miss-islington
Copy link
Contributor

Thanks @Akuli for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2020
@Akuli @miss-islington
bpo-41384: Raise TclError in tkinter.OptionMenu (pythonGH-21601)
47c4e4f 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit f1d40f9)

Co-authored-by: Akuli <akuviljanen17@gmail.com>
@bedevere-bot
Copy link

GH-21635 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 27, 2020
@bedevere-bot
Copy link

GH-21636 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jul 27, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2020
@Akuli @miss-islington
bpo-41384: Raise TclError in tkinter.OptionMenu (pythonGH-21601)
8a03f51 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit f1d40f9)

Co-authored-by: Akuli <akuviljanen17@gmail.com>
terryjreedy added a commit that referenced this pull request Jul 27, 2020
@miss-islington @terryjreedy @Akuli
bpo-41384: Raise TclError in tkinter.OptionMenu (GH-21601)
8b05275 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit f1d40f9)
Co-authored-by: Akuli <akuviljanen17@gmail.com>
terryjreedy added a commit that referenced this pull request Jul 27, 2020
@miss-islington @terryjreedy @Akuli
bpo-41384: Raise TclError in tkinter.OptionMenu (GH-21601)
104aded 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit f1d40f9)
Co-authored-by: Akuli <akuviljanen17@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@Akuli @terryjreedy @shihai1991
bpo-41384: Raise TclError in tkinter.OptionMenu (pythonGH-21601)
36457bb 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@Akuli @terryjreedy @shihai1991
bpo-41384: Raise TclError in tkinter.OptionMenu (pythonGH-21601)
9458adf 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@Akuli
Copy link
Contributor Author

Akuli commented Aug 21, 2020

I get @ mentioned every once in a while because someone screws up a git rebase and the bot reminds about my missing CLA. For now I'll try to silence all notifications coming from this repo. Please email me if there's something important.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@Akuli @terryjreedy
bpo-41384: Raise TclError in tkinter.OptionMenu (pythonGH-21601)
c72f4f8 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Akuli @the-knights-who-say-ni @csabella @tirkarthi @terryjreedy @serhiy-storchaka @miss-islington @bedevere-bot